Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quantile function #171

Closed
iuliadmtru opened this issue Jan 9, 2023 · 3 comments · Fixed by #172 or #181
Closed

quantile function #171

iuliadmtru opened this issue Jan 9, 2023 · 3 comments · Fixed by #172 or #181

Comments

@iuliadmtru
Copy link
Contributor

Is there a reason for this @smishr @ayushpatnaikgit? This happens in the singledesign branch. In the main branch, there used to be two different methods for SimpleRandomSample and StratifiedSample. Now that is not necessary, but there are two methods that are exactly the same. Can we delete one of them?
@smishr
Copy link
Contributor

smishr commented Jan 9, 2023

entire quantile file has to be rewritten i think. when that is done will remove both methods and add new.

@iuliadmtru iuliadmtru mentioned this issue Jan 10, 2023
Merged
@smishr smishr mentioned this issue Jan 10, 2023
Closed
4 tasks
@smishr
Copy link
Contributor

smishr commented Jan 10, 2023

Will be fixed with #172

@smishr smishr linked a pull request Jan 10, 2023 that will close this issue
Update survey design, add tests, remove extra quantile, add design.weights #172
Merged
@smishr smishr mentioned this issue Jan 15, 2023
Closed
12 tasks
@smishr smishr changed the title quantile function is defined twice quantile function CI Jan 19, 2023
@smishr
Copy link
Contributor

smishr commented Jan 22, 2023 •
edited
Loading

New function was added by #183 using bootstrap for variance. This issue will be closed when #181 is merged into main.

A general CI method is being planned in #184 , which entire API can use so no need for this issue anymore

@smishr smishr changed the title quantile function CI quantile function Jan 22, 2023
@smishr smishr linked a pull request Jan 22, 2023 that will close this issue
WIP: Merge singledesign into main #181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@smishr @iuliadmtru