Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dimnames.jl? #123

Closed
iuliadmtru opened this issue Dec 6, 2022 · 2 comments · Fixed by #181
Closed

Remove dimnames.jl? #123

iuliadmtru opened this issue Dec 6, 2022 · 2 comments · Fixed by #181
Assignees
@iuliadmtru

Comments

@iuliadmtru
Copy link
Contributor

This functionality is not really needed. It is simply calculating the size of the data frame used by the design. This is easily done using DataFrames.size. I suggest we remove it.
@smishr
Copy link
Contributor

smishr commented Dec 6, 2022

sounds good

@iuliadmtru
Copy link
Contributor Author

The src/ and test/ files were removed in PR #161. This issue should be closed after merging the singledesign branch into main.

@smishr smishr linked a pull request Jan 15, 2023 that will close this issue
WIP: Merge singledesign into main #181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iuliadmtru iuliadmtru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Merge singledesign into main xKDR/Survey.jl
2 participants
@smishr @iuliadmtru