Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON5 support #122

Open
robjtede opened this issue Aug 31, 2024 · 2 comments · May be fixed by #124
Open

JSON5 support #122

robjtede opened this issue Aug 31, 2024 · 2 comments · May be fixed by #124
Labels
enhancement New feature or request

Comments

@robjtede
Copy link
Member

robjtede commented Aug 31, 2024 •
edited
Loading

superset of JSON, supports comments etc which is nicer for config documentation sometimes
@robjtede robjtede added the enhancement New feature or request label Aug 31, 2024
@tenuous-guidance
Copy link
Contributor

There's json5. The main limitation is it doesn't support borrowed types but I'm not sure confik has much support for borrowed types anyway, although I'm not sure I've ever checked.

@robjtede
Copy link
Member Author

robjtede commented Sep 2, 2024

IMO that's a very reasonable compromise even if we currently support it.

@tenuous-guidance tenuous-guidance linked a pull request Sep 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: json5 source support tenuous-guidance/confik
2 participants
@robjtede @tenuous-guidance