Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Images at PDF Export #11

Open
TumTum opened this issue Jul 10, 2017 · 1 comment
Open

No Images at PDF Export #11

TumTum opened this issue Jul 10, 2017 · 1 comment

Comments

@TumTum
Copy link

TumTum commented Jul 10, 2017

Hi,

after install that Plugin, work all fine. But if I export a PDF that has no Images.
Can you that fixed?

Kind regards
Tobi

PS: I like your Docu, that was wrote good

@thorsten-de
Copy link

thorsten-de commented Jul 12, 2017

Investiating this issue, it seems that there's a more severe problem. In Redmine's codebase (V3.3). there are a bunch of usages of attachment.diskfile, and it is assumed to be a local file. If I run the redmine test suite, after enabling redmine_amazon_s3, I'll get some failures with the same pattern:
assert File.exist?(diskfile). They certainly fail, because the diskfile doesn't exist locally.

This is also directly connected to pdf export: Redmine only exports images which are attachments in that wiki page oder issue, and it checks whether the attachment is readble. Attachment#readable is defined as File.readable?(diskfile), so it'll never be readable if the file is stored on S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants