New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall message doesn't display #411

Closed

lukecarbis opened this issue Apr 15, 2014 · 1 comment · Fixed by #419

Labels

bug

Contributor

lukecarbis commented Apr 15, 2014

When clicking the Uninstall link on the plugins page, we should be displaying a warning notice (see https://github.com/x-team/wp-stream/blob/master/ui/admin.js#L276-L280).

This notice isn't displaying, because admin.js is never loaded, because the admin_enqueue_scripts hook never fires on the plugins page.

frankiejarrett added the bug label

Contributor

jonathanbardo commented Apr 18, 2014

I'll take care of this one!

jonathanbardo self-assigned this

jonathanbardo mentioned this issue

Fix plugins not being enqueued in plugins.php #419

Merged

frankiejarrett closed this as completed

lukecarbis unassigned jonathanbardo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment