New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong arguments passed to buffer::copy #7

Closed

refack opened this issue Oct 23, 2018 · 1 comment

refack commented Oct 23, 2018

Hello @wyhaya there's a bug in

updns/lib/parse.js

Lines 125 to 126 in 4fb62c6

    
           question.qtype.copy(buf, 12 + qname.length, question.qtype, 2) 
        
           question.qclass.copy(buf, 12 + qname.length + 2, question.qclass, 2)

The third argument should be a number indicating sourceStart, see https://nodejs.org/api/buffer.html#buffer_buf_copy_target_targetstart_sourcestart_sourceend

The text was updated successfully, but these errors were encountered:

refack mentioned this issue

[v10.x] buffer: fix crash for invalid index types nodejs/node#23795

Closed

3 tasks

Owner

wyhaya commented Aug 21, 2019

@refack Thank you, this problem does not exist anymore

wyhaya closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment