Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing null/undefined literals subexpressions #990

Closed
blimmer opened this issue Mar 30, 2015 · 6 comments
Closed

Allow passing null/undefined literals subexpressions #990

blimmer opened this issue Mar 30, 2015 · 6 comments

Comments

@blimmer
Copy link

blimmer commented Mar 30, 2015

I originally filed this on the Ember.JS tracker but was directed here, instead.

It would be really great if subexpressions could handle null and undefined literals. It doesn't appear to work that way currently. I have an EmberJS JSBin that shows the issue I'm talking about.

@mmun
Copy link
Contributor

mmun commented Mar 30, 2015

Not just subexpressions. They would need to fit anywhere an Expression can go.

In theory the HTMLBars parser could deal with this (by substituting any PathExpression whose original param is 'null' with a new NullLiteral node), but I'd prefer to get it merged into Handlebars so we don't diverge further.

@mmun
Copy link
Contributor

mmun commented Apr 8, 2015

Thank you!! :)

@mmun
Copy link
Contributor

mmun commented Apr 8, 2015

BTW your patch doesn't support {{null}} and {{undefined}} so it diverges from how boolean/number/etc are treated. I don't really care that much though. Sorry to be a pain...

@kpdecker
Copy link
Collaborator

@mmun, dfd141c adds support for null and undefined in the helper name/path section.

@mmun
Copy link
Contributor

mmun commented Apr 14, 2015

Thanks.

@kpdecker
Copy link
Collaborator

Released in 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants