fix(4.x): migrate from optimist to yargs #1666

fabb · 2020-03-29T13:39:18Z

Follow-up on #1662, added a few unit test on top of the original PR.

closes #1658
closes #1661

Note that there are not yet tests for all command line options. I know too little about handlebars yet (it's just a sub-sub-dependency of a package I use). If someone has good suggestions on what makes sense to test, fire away, I will update the PR.

Since I use npm audit to fail my build to not get vulnerable packages get released to production, I'm very interested into getting this merged.

Tested:

aorinevo · 2020-03-29T16:34:18Z

I recommend looking at yargs unit tests and maybe mimicking what is done there to test handlebars cli options.

@fabb, happy to help on this, can I get permissions to your fork?

aorinevo · 2020-03-29T17:17:08Z

Seems like the unit testing structure in place will make this some what difficult.

Will try to leverage the current unit testing structure to get this done.

fabb · 2020-03-29T17:19:16Z

@aorinevo I invited you to this repo, feel free to commit to this branch, thanks for offering! I‘ll probably only get to continue on this in 2 days. I‘ll then have a look at what you‘ve done in the mean time, and at the yargs tests as you suggested. I guess for coordination it should be enough when we write here in this PR when we start and stop making changes, what do you think?

aorinevo · 2020-03-29T17:20:10Z

I think that makes sense. I'll update with comments accordingly.

aorinevo · 2020-03-29T17:33:44Z

aorinevo · 2020-03-29T19:08:46Z

@fabb, please give me a heads up before merging any changes from your end on this branch. I'd like to squash my commits into one; it's easier if there are no interwoven commits from other contributors.

aorinevo · 2020-03-29T19:43:39Z

@fabb, unfortunately I squashed your commits down with mine.

If you have those commits locally, I can add them back. Just push them to a branch called faab-mty-commits and I'll take it from there.

closes handlebars-lang#1658 adapted code from master to latest yargs (`.option` calls). ``` 4.x: found 188 vulnerabilities (169 low, 4 moderate, 14 high, 1 critical) in 5815 scanned packages 4.x with this PR: found 32 vulnerabilities (17 low, 1 moderate, 13 high, 1 critical) in 5829 scanned packages ```

some indirect dependencies install @types packages which are not compatible with the older typescript. adjusted test's tsconfig to not pick these up automatically, as the actual .d.ts does not depend on these external types.

aorinevo · 2020-03-29T20:05:55Z

Added back @AviVahl's commits.

aorinevo · 2020-03-29T20:24:31Z

Going to pause here for a bit.

Added unit tests for 8 options. Might pick this up again later.

fabb · 2020-03-30T06:41:32Z

@fabb, unfortunately I squashed your commits down with mine.
If you have those commits locally, I can add them back. Just push them to a branch called faab-mty-commits and I'll take it from there.

I'm not here for fame, so it's fine with me ;-)

fabb · 2020-03-30T06:44:41Z

spec/expected/version.txt

@@ -0,0 +1 @@
+4.7.3


maybe we can read out the dynamic value from package.json to make updating less annoying

That would really be preferable! It's possible to do e.g. require('path/to/package.json').version

Might require reworking the task runner but definitely doable and a better approach.

another approach might be just verifying that the output is /\d+\.\d+\.\d+/ but I wouldn't worry about missing a test for this one command if it's too fiddly.

Main thing is that having this fail after every release would be a major maintenance burden 😅

Like most things, this ended up being pretty straight forward 🥳.

This file can be removed now.

ErisDS · 2020-03-30T14:56:04Z

@fabb and @aorinevo Thanks so much for taking this on. I'll be supporting this PR through to release.

If anyone out there regularly uses the handlebars CLI and can verify this PR is working for them, that would be fantastic.

Otherwise I'll give this a spin once you're both happy it's done.

aorinevo · 2020-03-30T15:34:53Z

Thanks @ErisDS, I’ll try to get this wrapped up tonight :)

aorinevo · 2020-03-30T21:22:54Z

@fabb, picking this backup now. Let me know if you have any WIP.

aorinevo · 2020-03-30T23:19:35Z

@ErisDS, I'd like to recommend skipping a unit test for -b as use of BOM is not required or recommended (see https://en.wikipedia.org/wiki/Byte_order_mark).

Thoughts?

aorinevo · 2020-03-30T23:58:30Z

@ErisDS, assuming we skip -b, this PR is ready for review.

aorinevo · 2020-03-31T00:27:06Z

Cause I'm stubborn, I added the last remaining unit test for -b.

Unit test is valid as it runs against a file that includes a BOM (see image below).

DeeDeeG · 2020-03-31T03:23:44Z

~~Edit: In hindsight, I'm pretty sure the proper thing would have been to just wait for a review from someone who knows these things. Hiding my comment as off-topic for now.~~ Un-hidden for context.

(Disclaimer: This is just something I tried in the volunteer spirit, while we wait for a proper review. I am not fluent with JS projects, so take this with a grain of salt/feel free to ignore if it is not helpful. Apologies in advance if that is the case.)

Should these tests pass with the old optimist-based code dropped in place of the new yargs code? I tried to do this (new tests, old code/dependencies) and it failed, but it may have been a mistake on my end.

(My Travis runs can be viewed here: https://travis-ci.com/github/DeeDeeG/handlebars.js/branches)

aorinevo · 2020-03-31T04:00:47Z

@DeeDeeG, I'm rather curious myself why that's the case. I'm going to take a look.

This was referenced Mar 29, 2020

Peer Dependency has Security Vulnerability #1661

Closed

fix(4.x): migrate from optimist to yargs #1662

Closed

aorinevo force-pushed the migrate-to-yargs branch 2 times, most recently from d86addc to 1e1831f Compare March 29, 2020 19:41

AviVahl added 2 commits March 29, 2020 15:59

fix: ensure external @types aren't picked up in test

01ab830

some indirect dependencies install @types packages which are not compatible with the older typescript. adjusted test's tsconfig to not pick these up automatically, as the actual .d.ts does not depend on these external types.

aorinevo force-pushed the migrate-to-yargs branch from d8c33f0 to e4ae377 Compare March 29, 2020 20:05

fabb commented Mar 30, 2020

View reviewed changes

yumetodo mentioned this pull request Mar 30, 2020

fix: 2020/03 npm update dependencies jaredwray/flat-cache#46

Merged

chore: add unit tests for cli options.

5e6a255

aorinevo force-pushed the migrate-to-yargs branch from a7ff52c to 5e6a255 Compare March 30, 2020 23:52

chore: add unit test for -b.

c149460

sync-by-unito bot mentioned this pull request Mar 25, 2022

Bump handlebars from 4.1.2 to 4.7.7 in /ethereum Moliholy/QuantumFS#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(4.x): migrate from optimist to yargs #1666

fix(4.x): migrate from optimist to yargs #1666

fabb commented Mar 29, 2020 •

edited

Loading

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

fabb commented Mar 29, 2020

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020 •

edited

Loading

aorinevo commented Mar 29, 2020 •

edited

Loading

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

fabb commented Mar 30, 2020

fabb Mar 30, 2020

ErisDS Mar 30, 2020 •

edited

Loading

aorinevo Mar 30, 2020

ErisDS Mar 30, 2020

aorinevo Mar 30, 2020

aorinevo Mar 31, 2020

ErisDS commented Mar 30, 2020

aorinevo commented Mar 30, 2020

aorinevo commented Mar 30, 2020

aorinevo commented Mar 30, 2020 •

edited

Loading

aorinevo commented Mar 30, 2020

aorinevo commented Mar 31, 2020 •

edited

Loading

DeeDeeG commented Mar 31, 2020 •

edited

Loading

aorinevo commented Mar 31, 2020

		@@ -0,0 +1 @@
		4.7.3

fix(4.x): migrate from optimist to yargs #1666

fix(4.x): migrate from optimist to yargs #1666

Conversation

fabb commented Mar 29, 2020 • edited Loading

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

fabb commented Mar 29, 2020

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020 • edited Loading

aorinevo commented Mar 29, 2020 • edited Loading

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

aorinevo commented Mar 29, 2020

fabb commented Mar 30, 2020

fabb Mar 30, 2020

Choose a reason for hiding this comment

ErisDS Mar 30, 2020 • edited Loading

Choose a reason for hiding this comment

aorinevo Mar 30, 2020

Choose a reason for hiding this comment

ErisDS Mar 30, 2020

Choose a reason for hiding this comment

aorinevo Mar 30, 2020

Choose a reason for hiding this comment

aorinevo Mar 31, 2020

Choose a reason for hiding this comment

ErisDS commented Mar 30, 2020

aorinevo commented Mar 30, 2020

aorinevo commented Mar 30, 2020

aorinevo commented Mar 30, 2020 • edited Loading

aorinevo commented Mar 30, 2020

aorinevo commented Mar 31, 2020 • edited Loading

DeeDeeG commented Mar 31, 2020 • edited Loading

aorinevo commented Mar 31, 2020

fabb commented Mar 29, 2020 •

edited

Loading

aorinevo commented Mar 29, 2020 •

edited

Loading

aorinevo commented Mar 29, 2020 •

edited

Loading

ErisDS Mar 30, 2020 •

edited

Loading

aorinevo commented Mar 30, 2020 •

edited

Loading

aorinevo commented Mar 31, 2020 •

edited

Loading

DeeDeeG commented Mar 31, 2020 •

edited

Loading