Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bringing back the old loudness compensation plugin #820

Closed
Mlocik97 opened this issue Nov 11, 2020 · 11 comments
Closed

bringing back the old loudness compensation plugin #820

Mlocik97 opened this issue Nov 11, 2020 · 11 comments

Comments

@Mlocik97
Copy link
Contributor

As I mailed with @wwmm , we should bring back old loudness compensation plugin next to new one. New one is really good, but there are situations (mainly, if You have dedicated subwoofer (2.1 audio system)) when old one was better to compensate loudness of bass, because it was applied only on bass frequencies, instead whole spectrum like new one. They also use differend loudness contours (specifically Stevens-Davis equal loudness contours) that is differend from LSP plugin contours. @wwmm suggested to bring it back as another loudness compensator named "Bass Loudness compensation".

@Mlocik97
Copy link
Contributor Author

Can I ask how a lot of work would this require,... bcs. I think, if it already was in PE, it should need to just copy code from old commits,... can I create PR for this? I'm not that good with C++, so I will propably need some help, but I would like to work on this, bcs I really need this feature.

@wwmm
Copy link
Owner

wwmm commented Mar 12, 2021

if it already was in PE, it should need to just copy code from old commits

As the master branch still is using GStreamer it will be enough to do that. For the release based on GTK4 things will be different
because I decided to move from GStreamer to PipeWire's native filters. At this moment I am doing that in the autogain https://github.com/wwmm/pulseeffects/blob/gtk4/src/autogain.cpp.

In case you want to have a local build in your computer with this plugin available I can help you. But I think that merging this work with the master branch won't be a good idea. It may make things more complicated when merging the GTK4 and the master branch.

For the GTK4 I will probably need to write a wrapper for LADSPA plugins besides the one for LV2 plugins I am already writing https://github.com/wwmm/pulseeffects/blob/gtk4/src/lv2_wrapper.cpp. Depending on the MDA plugin license another possibility would be to port its code to a PipeWire filter like I am doing in the autogain. PipeWire's filters API is very simple to use.

@Mlocik97
Copy link
Contributor Author

I still use 4.7.X, and if implementing it now would be inefficient, because of changes in GTK4 port, that will need to work on it again, then I think, I will just wait for now. And when it will be ported to GTK4, then I will look on it.

@Mlocik97
Copy link
Contributor Author

Ok, I will try to create fork with old loudness plugin, could You please assist me?

https://github.com/Mlocik97/pulseeffects/issues/1

@wwmm
Copy link
Owner

wwmm commented Jul 10, 2021

The new update to the master branch has the MDA loudness plugin
Screenshot from 2021-07-10 14-19-02

As expected it was easy to do. I mean... The overall process of adding a plugin to EasyEffects is as painful if not more than it was in PulseEffects. But as I have all the steps in my head it was fast. This is something that should be improved in the future but I do not know how. It is way too difficult for new contributors to add plugins. This is not good.

As it happens with all the others plugins in EasyEffects you can use it in both pipelines. It is not restricted to the output effects anymore.

@wwmm
Copy link
Owner

wwmm commented Jul 10, 2021

I named it Bass Loudness but I am not sure if it is conceptually accurate. The plugins description gives that impression. But looking at its code it is not obvious if only the low frequencies are being corrected. I did not understand the algorithm.

@Mlocik97
Copy link
Contributor Author

Mlocik97 commented Jul 10, 2021

Thank you so much for adding plugin and all your work...

I'm not sure about how algorithm work, but because I used that plugin for some time and was playing a lot with it's settings, from what I hear I can say it affects only low frequencies. It watch higher frequencies, but doesn't affect them. Mainly when kick happen, it create more "steeper hill" on spectogram in low frequency, but it keeps wide of original bass, so it sounds like the bass has bigger depth and loudness range, but it increase loudness volume as well. I'm not sure of how exactly it works and how it change, but by what I can hear, without this plugin, my subwoofer sound like when you're thrashing the rug, and when it's on, it sound more like when you thrash really big tambour.

(hope my bad English is good enough to understand)

@wwmm
Copy link
Owner

wwmm commented Jul 10, 2021

I see. In any case we can close this issue.

@wwmm wwmm closed this as completed Jul 10, 2021
@Neo595
Copy link

Neo595 commented Jan 12, 2022

Hello,
The path to the plugin has changed, so easyeffects is no more able to load it.
(easyeffects:2): easyeffects-WARNING **: 13:03:07.180: lv2_wrapper: Could not find the plugin: http://drobilla.net/plugins/mda/Loudness
Is it possible to point to new link or even point to a local file ?
Thanks in advance

@wwmm
Copy link
Owner

wwmm commented Jan 12, 2022

It has not changed. I just tried it now and it works. I think that what is happening is that you do not have the MDA plugins package installed.

@Neo595
Copy link

Neo595 commented Jan 12, 2022

Hello, Thanks. It is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants