-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bringing back the old loudness compensation plugin #820
Comments
Can I ask how a lot of work would this require,... bcs. I think, if it already was in PE, it should need to just copy code from old commits,... can I create PR for this? I'm not that good with C++, so I will propably need some help, but I would like to work on this, bcs I really need this feature. |
As the master branch still is using GStreamer it will be enough to do that. For the release based on GTK4 things will be different In case you want to have a local build in your computer with this plugin available I can help you. But I think that merging this work with the master branch won't be a good idea. It may make things more complicated when merging the GTK4 and the master branch. For the GTK4 I will probably need to write a wrapper for LADSPA plugins besides the one for LV2 plugins I am already writing https://github.com/wwmm/pulseeffects/blob/gtk4/src/lv2_wrapper.cpp. Depending on the MDA plugin license another possibility would be to port its code to a PipeWire filter like I am doing in the autogain. PipeWire's filters API is very simple to use. |
I still use 4.7.X, and if implementing it now would be inefficient, because of changes in GTK4 port, that will need to work on it again, then I think, I will just wait for now. And when it will be ported to GTK4, then I will look on it. |
Ok, I will try to create fork with old loudness plugin, could You please assist me? |
I named it |
Thank you so much for adding plugin and all your work... I'm not sure about how algorithm work, but because I used that plugin for some time and was playing a lot with it's settings, from what I hear I can say it affects only low frequencies. It watch higher frequencies, but doesn't affect them. Mainly when kick happen, it create more "steeper hill" on spectogram in low frequency, but it keeps wide of original bass, so it sounds like the bass has bigger depth and loudness range, but it increase loudness volume as well. I'm not sure of how exactly it works and how it change, but by what I can hear, without this plugin, my subwoofer sound like when you're thrashing the rug, and when it's on, it sound more like when you thrash really big tambour. (hope my bad English is good enough to understand) |
I see. In any case we can close this issue. |
Hello, |
It has not changed. I just tried it now and it works. I think that what is happening is that you do not have the |
Hello, Thanks. It is working. |
As I mailed with @wwmm , we should bring back old loudness compensation plugin next to new one. New one is really good, but there are situations (mainly, if You have dedicated subwoofer (2.1 audio system)) when old one was better to compensate loudness of bass, because it was applied only on bass frequencies, instead whole spectrum like new one. They also use differend loudness contours (specifically Stevens-Davis equal loudness contours) that is differend from LSP plugin contours. @wwmm suggested to bring it back as another loudness compensator named "Bass Loudness compensation".
The text was updated successfully, but these errors were encountered: