From ded71599d8449097587d29f75df2a30849790c38 Mon Sep 17 00:00:00 2001
From: Yizhi Liu <liuyizhi@apache.org>
Date: Thu, 14 Mar 2019 16:07:32 -0700
Subject: [PATCH] upgrade java style-check due to CVE-2019-9658 (#2817)

---
 jvm/conf/google_checks.xml                                   | 3 ---
 jvm/core/pom.xml                                             | 2 +-
 jvm/core/src/main/java/ml/dmlc/tvm/Base.java                 | 2 +-
 jvm/core/src/main/java/ml/dmlc/tvm/Function.java             | 2 +-
 jvm/core/src/main/java/ml/dmlc/tvm/Module.java               | 1 +
 jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java          | 2 +-
 jvm/core/src/main/java/ml/dmlc/tvm/contrib/GraphModule.java  | 2 +-
 jvm/core/src/main/java/ml/dmlc/tvm/rpc/NativeServerLoop.java | 2 +-
 8 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/jvm/conf/google_checks.xml b/jvm/conf/google_checks.xml
index 0ae8c338bf05..9bea0e85f46f 100644
--- a/jvm/conf/google_checks.xml
+++ b/jvm/conf/google_checks.xml
@@ -57,9 +57,6 @@
             <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
         </module>
         <module name="NeedBraces"/>
-        <module name="LeftCurly">
-            <property name="maxLineLength" value="100"/>
-        </module>
         <module name="RightCurly"/>
         <module name="RightCurly">
             <property name="option" value="alone"/>
diff --git a/jvm/core/pom.xml b/jvm/core/pom.xml
index 9ffdba16f5ba..b2c92589c3bb 100644
--- a/jvm/core/pom.xml
+++ b/jvm/core/pom.xml
@@ -57,7 +57,7 @@
           <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>6.12</version>
+            <version>[8.18,)</version>
           </dependency>
         </dependencies>
         <executions>
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/Base.java b/jvm/core/src/main/java/ml/dmlc/tvm/Base.java
index d380cf5a07c2..2684bdb77635 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/Base.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/Base.java
@@ -161,7 +161,7 @@ private static void tryLoadLibraryXPU(String libname, String arch) throws Unsati
 
   // helper function definitions
   /**
-   * Check the return value of C API call
+   * Check the return value of C API call.
    * <p>
    * This function will raise exception when error occurs.
    * Wrap every API call with this function
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/Function.java b/jvm/core/src/main/java/ml/dmlc/tvm/Function.java
index 2e21f439300e..a1939a25727a 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/Function.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/Function.java
@@ -75,7 +75,7 @@ private static Function getGlobalFunc(String name, boolean isResident, boolean a
   }
 
   /**
-   * Initialize the function with handle
+   * Initialize the function with handle.
    * @param handle the handle to the underlying function.
    * @param isResident Whether this is a resident function in jvm
    */
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/Module.java b/jvm/core/src/main/java/ml/dmlc/tvm/Module.java
index 7c55add36639..b446ef10a680 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/Module.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/Module.java
@@ -122,6 +122,7 @@ public void importModule(Module module) {
   }
 
   /**
+   * Get type key of the module.
    * @return type key of the module.
    */
   public String typeKey() {
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java b/jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java
index 11c77207fd1c..ff75bf9489b9 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/NDArrayBase.java
@@ -45,7 +45,7 @@ public class NDArrayBase extends TVMValue {
   }
 
   /**
-   * Copy array to target
+   * Copy array to target.
    * @param target The target array to be copied, must have same shape as this array.
    * @return target
    */
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/contrib/GraphModule.java b/jvm/core/src/main/java/ml/dmlc/tvm/contrib/GraphModule.java
index 208006886cac..84f8fc2a1a95 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/contrib/GraphModule.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/contrib/GraphModule.java
@@ -72,7 +72,7 @@ public GraphModule setInput(String key, NDArray value) {
   }
 
   /**
-   * Set inputs to the module
+   * Set inputs to the module.
    * @param key The input key.
    * @param value The input value.
    * @return self.
diff --git a/jvm/core/src/main/java/ml/dmlc/tvm/rpc/NativeServerLoop.java b/jvm/core/src/main/java/ml/dmlc/tvm/rpc/NativeServerLoop.java
index 666b15aed615..255dabb438d5 100644
--- a/jvm/core/src/main/java/ml/dmlc/tvm/rpc/NativeServerLoop.java
+++ b/jvm/core/src/main/java/ml/dmlc/tvm/rpc/NativeServerLoop.java
@@ -31,7 +31,7 @@ public class NativeServerLoop implements Runnable {
   private final int sockFd;
 
   /**
-   * Constructor for NativeServerLoop
+   * Constructor for NativeServerLoop.
    * @param nativeSockFd native socket file descriptor.
    */
   public NativeServerLoop(final int nativeSockFd) {