Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minOffset to bar chart #979

Open
philipheinser opened this issue Nov 9, 2023 · 0 comments
Open

add minOffset to bar chart #979

philipheinser opened this issue Nov 9, 2023 · 0 comments

Comments

@philipheinser
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
index 4737c70..bdd1069 100644
--- a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
+++ b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
@@ -28,6 +28,7 @@ RCT_EXPORT_VIEW_PROPERTY(doubleTapToZoomEnabled, BOOL) \
 RCT_EXPORT_VIEW_PROPERTY(zoom, NSDictionary) \
 RCT_EXPORT_VIEW_PROPERTY(viewPortOffsets, NSDictionary) \
 RCT_EXPORT_VIEW_PROPERTY(extraOffsets, NSDictionary) \
+RCT_EXPORT_VIEW_PROPERTY(minOffset, NSNumber) \
 RCT_EXPORT_VIEW_PROPERTY(onYaxisMinMaxChange, RCTBubblingEventBlock) \
 RCT_EXTERN_METHOD(moveViewToX:(nonnull NSNumber *)node xValue:(nonnull NSNumber *)xValue) \
 RCT_EXTERN_METHOD(moveViewTo:(nonnull NSNumber *)node xValue:(nonnull NSNumber *)xValue yValue:(nonnull NSNumber *)yValue axisDependency:(nonnull NSString *)axisDependency) \
diff --git a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
index a1fd7d5..631b73e 100644
--- a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
+++ b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
@@ -233,6 +233,10 @@ class RNBarLineChartViewBase: RNYAxisChartViewBase {
         barLineChart.setExtraOffsets(left: left, top: top, right: right, bottom: bottom)
     }
     
+    func setMinOffset(_ config: NSNumber) {
+        barLineChart.minOffset = CGFloat(config.doubleValue);
+    }
+
     override func onAfterDataSetChanged() {
         super.onAfterDataSetChanged()
 

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant