Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During project initialization apply public access prevention flag to bucket #27

Closed
malachig opened this issue Oct 26, 2022 · 1 comment · Fixed by #29
Closed

During project initialization apply public access prevention flag to bucket #27

malachig opened this issue Oct 26, 2022 · 1 comment · Fixed by #29

Comments

@malachig
Copy link
Member

As an extra safety measure on the project bucket that will be used to store data, experiment with adding the public access prevention flag:

https://cloud.google.com/storage/docs/using-public-access-prevention#command-line

Still to be determined. What IAM permissions are needed to remove this flag? Can we easily have a setup where a limited number of users can control this? This might require users to work with an admin during their project setup phase. Even having the flag set at least produces additional warnings and makes it slightly harder for a user to accidentally set a bucket to have public access.

@malachig
Copy link
Member Author

malachig commented Dec 1, 2022

To test this we would add this command to the script that creates our bucket:

gsutil pap set enforced gs://BUCKET_NAME

Maybe somewhere around here:
https://github.com/griffithlab/cloud-workflows/blob/2984870563dffa7709da3ff22c42492dfe4561eb/scripts/create_resources.sh#L69

@Layth17 Layth17 linked a pull request Dec 1, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant