Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): allow exclusion of OTLP metrics via configuration #1359

Conversation

Noroth
Copy link
Contributor

@Noroth Noroth commented Nov 11, 2024

Motivation and Context

Currently we can only exclude metrics and labels from Prometheus.
This PR adds an option to the configuration to do the exact same for the OTLP metrics configuration.

Checklist

@Noroth Noroth marked this pull request as ready for review November 11, 2024 13:54
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noroth Noroth merged commit 31a583e into main Nov 12, 2024
9 checks passed
@Noroth Noroth deleted the ludwig/eng-5912-allow-to-ignore-otlp-metric-fields-to-reduce-cardinality branch November 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants