feat(router): allow users to have multiple wildcards cores allow_origins #1358
+445
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aenimus
reviewed
Nov 10, 2024
Aenimus
reviewed
Nov 10, 2024
StarpTech
requested changes
Nov 11, 2024
df-wg
force-pushed
the
dave/eng-5826-support-multiple-wildcards-in-allow-_origins-cors-config
branch
from
28cc44b
to
53cf22e
Compare
|
Bench with wildcard: Bench without wildcard: |
df-wg
force-pushed
the
dave/eng-5826-support-multiple-wildcards-in-allow-_origins-cors-config
branch
from
573ae6a
to
23cab73
Compare
df-wg
deleted the
dave/eng-5826-support-multiple-wildcards-in-allow-_origins-cors-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A previous effort, #880, gave the initial steps to enabling multiple wildcards in
cors.allow_origins. This PR takes it further, ensuring that we can handle a config with the configuration:Closes #879
Checklist