Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and Appearance #9

Open
wtheisen opened this issue Jul 21, 2019 · 11 comments
Open

Layout and Appearance #9

wtheisen opened this issue Jul 21, 2019 · 11 comments

Comments

@wtheisen
Copy link
Owner

@sambattalio and @ginglis13 what do you guys think of the layout of the views. I’m starting to think that we could make a much better and more useful looking layout. Right now overlaying in a single pane looks nice but it doesn’t provide any extra utility. what are your thoughts on an appearance rewrite?

@wtheisen
Copy link
Owner Author

As an aside I'd probably write all the code myself I just want opinions on what makes sense

@sambattalio
Copy link
Collaborator

I think an appearance rewrite with tree view in mind would be definitely useful. I definitely agree on doing a rewrite.

@ginglis13
Copy link
Collaborator

agreed yea tree view would be nice. maybe whenever you go a level deeper, the whole screen clears to just show that level, with a tree view of the levels to the side? or maybe even post names to the side? idk. def think a layout rewrite could be cool

@wtheisen
Copy link
Owner Author

So I was thinking of trying to further emulate vim by having an idea of view that would display frames.
Where a view would be like a split in vim and a frame would be a proxy for a file. So we could have a history frame, a thread frame, board frame etc. etc. Per the reddit idea I agree it has to be a tree unless we decided to override the LineBox class to add indentation levels to it

@wtheisen
Copy link
Owner Author

I started working on the split code yesterday and I made a little progress but it's going to be tricky

@wtheisen
Copy link
Owner Author

Oh yeah i also think there's no reason to have it continue being an overlay object, it looks nice but it doesn't add anything other than that.

@sambattalio
Copy link
Collaborator

I like the vim emulation idea. If you need help with tree view for reddit I can definitely try to take the charge on it if you need (since I assume you might prefer working on 4chan over reddit)

@wtheisen
Copy link
Owner Author

http://urwid.org/examples/index.html

There is a browse.py example that implements a tree view with collapsing and expanding

@sambattalio
Copy link
Collaborator

aight i got u thanks

@noyoshi
Copy link
Contributor

noyoshi commented Aug 4, 2019

I think that doing something like highlighting important text like user names, subreddit / board names, etc, might be nice, that way you can easily see whats on the default frame when you load up a view.

@wtheisen
Copy link
Owner Author

wtheisen commented Aug 5, 2019

I also think we need to add some sort of bookmarking ability. This could probably be done really easily using the already existing history list/Frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants