You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So frames need to have member variables and right now they're stored as actual variables of the class. However I think as we move forward this might cause problems with extensibility. I was thinking it might make more sense to instead have a single dictionary in each frames called "options" or something and then the code can just store any kind of value it likes. This also allows code to make assumptions that a variable is there and means we don't need to keep adding member variables into frames.
It would allow frames to customize and assume a lot of things at a significant cost of standardization. The more I think about it the more we should probably do a mixture of the two. Keep SITE as a member variable but maybe break some of the more specific stuff out into a dict?
So frames need to have member variables and right now they're stored as actual variables of the class. However I think as we move forward this might cause problems with extensibility. I was thinking it might make more sense to instead have a single dictionary in each frames called "options" or something and then the code can just store any kind of value it likes. This also allows code to make assumptions that a variable is there and means we don't need to keep adding member variables into frames.
What do you guys think about that?
@sambattalio @ginglis13
The text was updated successfully, but these errors were encountered: