Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module template seems quite outdated #748

Closed
schoentoon opened this issue Nov 12, 2019 · 3 comments · Fixed by #786
Closed

Module template seems quite outdated #748

schoentoon opened this issue Nov 12, 2019 · 3 comments · Fixed by #786
Labels
🐛 bug "Houston, we've had a problem."

Comments

@schoentoon
Copy link
Contributor

What's broken?

After having followed the instructions at https://wtfutil.com/configuration/generate-module/ and started working on my module, I first had to figure out that I had to add my widget to the long list at https://github.com/wtfutil/wtf/blob/master/app/widget_maker.go
After which I came to the conclusion that a newly generated module wouldn't compile. The wtf.TextWidget had to be changed to view.TextWidget for example.
Perhaps this template should be updated, maybe the generate part could output that you should add your widget to https://github.com/wtfutil/wtf/blob/master/app/widget_maker.go
Perhaps it could even be added to integration tests so this breaking in the future will sooner be realized.

@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Nov 12, 2019
@senorprogrammer
Copy link
Collaborator

Agreed, it's really impractical at the moment.

@3mard
Copy link
Contributor

3mard commented Nov 14, 2019

I can take care of this :)

@senorprogrammer
Copy link
Collaborator

Fixed. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug "Houston, we've had a problem."
Development

Successfully merging a pull request may close this issue.

3 participants