Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend github module for more maintainer tools #469

Closed
Sean-Der opened this issue Jun 1, 2019 · 5 comments · Fixed by #473
Closed

Extend github module for more maintainer tools #469

Sean-Der opened this issue Jun 1, 2019 · 5 comments · Fixed by #473
Labels
💥 feature "Good luck, you're gonna need it."

Comments

@Sean-Der
Copy link
Contributor

Sean-Der commented Jun 1, 2019

@senorprogrammer fantastic tool! I don't often use new things, but wtf is really delightful to use :)

What problem does this solve?

I am trying to find a way to display stats on a bunch of little repos. With Pion I lose track of issues/PRs that others open.

It would be great if I could

  • See unassigned issues (or those not assigned to me?) I want to make sure things get closed
  • See PRs that aren't mine (make sure I review them and keep on top of them)

How do envision it working?

I hacked this up myself but everything is hardcoded https://imgur.com/a/guChCrL

If you don't mind spec'ing this out, I am more then happy to implement it myself :)

@senorprogrammer senorprogrammer added the 💥 feature "Good luck, you're gonna need it." label Jun 2, 2019
@senorprogrammer
Copy link
Collaborator

senorprogrammer commented Jun 2, 2019

Interesting idea. For the PRs that aren't assigned, this should be relatively straight-forward. github_repo.go:102 does the filtering for username. I could see adding a showAllPullRequests boolean config option that if true displays all not-my PRs under "My Pull Requests", perhaps as "Other Pull Requests". If that config option is missing, default to false to maintain backwards compatibility.

For issues, right now there's no capability for that so perhaps starting with just showing all open issues and adding complexity later if warranted?

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Jun 2, 2019

showAllPullRequests would be great for me! Happy to submit that

For issues what would you like to see those config options look like?

Another idea that might be cool is allow people to create arbitrary lists/filters. We could do an array and let people specify

type: [issue, pr]
title: 'My special list'
filter: 'is:open is:issue author:Sean-Der'

@senorprogrammer
Copy link
Collaborator

senorprogrammer commented Jun 3, 2019

For that it would be great to see a proof-of-concept branch as to how that might work. It sounds good to me in concept. For filtering, what about something like:

    filter:
    - "is:open"
    - "is:issue"
    - "author:Sean-Der"

Also, what does title refer to in the config above?

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Jun 7, 2019

Is there any other cleanup/docs you would like to see @senorprogrammer? Thanks again for making wtf want to make sure I leave it better then I found it :)

@senorprogrammer
Copy link
Collaborator

All good, I've added some documentation to the GitHub page on the site: https://wtfutil.com/modules/github/ Effectively just the examples you provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 feature "Good luck, you're gonna need it."
Development

Successfully merging a pull request may close this issue.

2 participants