Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support organization resource access with tenant & organization perspective #17120

Closed
sadilchamishka opened this issue Oct 23, 2023 · 1 comment · Fixed by wso2/carbon-identity-framework#5114

Comments

@sadilchamishka
Copy link
Contributor

sadilchamishka commented Oct 23, 2023

Describe the issue:

The organization resources should be accessible in tenant perspective and organization perspective.

  • The tenant perspective resource access - /t/<tenant-domain>/api/server/v1/applications
  • The organization perspective resource access - /t/<tenant-domain>/o/api/server/v1/applications

Each perspective has separate personas and use cases. Identity server should support for these cases.

@dewniMW
Copy link
Contributor

dewniMW commented Oct 23, 2023

In the on-prem console for the primary org (super tenant), currently endpoint paths are in the format o/10084a8d-113f-4211-a0d5-efe36b082211. Internally there can be logics that is written to fetch the organization ID from context (https://github.com/wso2-extensions/identity-organization-management/blob/a9c1db770a29370bd02e023b3f975a34ea5b954d/components/org.wso2.carbon.identity.organization.management.application/src/main/java/org/wso2/carbon/identity/organization/management/application/OrgApplicationManagerImpl.java#L254). With the aforementioned improvement this would be null for super tenant). If so those flows might be impacted due to this. Therefore let's confirm that there are no breaking changes due to this.

Another place that can break is https://github.com/wso2-extensions/identity-organization-management/blob/a9c1db770a29370bd02e023b3f975a34ea5b954d/components/org.wso2.carbon.identity.organization.management.application/src/main/java/org/wso2/carbon/identity/organization/management/application/OrgApplicationManagerImpl.java#L147-L150. Here if the organization ID is not set in the context we have set it as super org ID. But with this improvement, this assumption will be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants