-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Hybrid Role-V2 Manager #3690
Conversation
@@ -28,7 +28,7 @@ | |||
|
|||
public class AdvancedHybridRoleManagerTest extends BaseTestCase { | |||
|
|||
private HybridRoleManager hybridRoleMan; | |||
private HybridRoleV2Manager hybridRoleMan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HybridRoleManagerV2?
@@ -196,6 +214,12 @@ public ReadWriteLDAPUserStoreManager(RealmConfiguration realmConfig, | |||
} | |||
} | |||
|
|||
private boolean isUsingRoleV2() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isUsingV2Role?
...so2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/hybrid/HybridRoleV2Manager.java
Show resolved
Hide resolved
...so2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/hybrid/HybridRoleV2Manager.java
Show resolved
Hide resolved
...so2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/hybrid/HybridRoleV2Manager.java
Show resolved
Hide resolved
...so2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/hybrid/HybridRoleV2Manager.java
Show resolved
Hide resolved
int tenantId, String domain, String filter) | ||
throws UserStoreException { | ||
|
||
PreparedStatement prepStmt = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use try with resources all the places
duplicate of : #3700 |
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning