Improve claim provider according to the organization bound token improvements #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewniMW
pushed a commit
to dewniMW/identity-organization-management-1
that referenced
this pull request
Sep 20, 2023
… release v1.3.12
dewniMW
pushed a commit
to dewniMW/identity-organization-management-1
that referenced
this pull request
Sep 20, 2023
… for next development iteration
sadilchamishka
force-pushed
the
improve-claim-provider
branch
from
8e1f25a to
5804d1d
Compare
sadilchamishka
changed the title
sadilchamishka
changed the title
sadilchamishka
force-pushed
the
improve-claim-provider
branch
from
5804d1d to
dbce554
Compare
sadilchamishka
changed the title
thanujalk
reviewed
Oct 17, 2023
Comment on lines
94
to
95
| private Map<String, Object> setOrganizationInformation(String userResidentOrganization, | ||
| String authorizedOrganization) |
There was a problem hiding this comment.
Suggested change
| private Map<String, Object> setOrganizationInformation(String userResidentOrganization, | |
| String authorizedOrganization) | |
| private Map<String, Object> buildOrganizationInformation(String userResidentOrganizationId, | |
| String authorizedOrganizationId) |
thanujalk
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
According to the organization bound token improvement, the user accessing organization should be fetch from the newly introduced attributes of the authenticated user object.
Also the user's resident organization information also need to fetched and added to the ID token as an additional claim.
Related Issues.
When should this PR be merged
Depends on