Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit SHA to the nightly builds #675

Open
Utumno opened this issue Jan 18, 2024 · 2 comments
Open

Add commit SHA to the nightly builds #675

Utumno opened this issue Jan 18, 2024 · 2 comments
Labels
A-build Area: build wrye Bash (nightlies to release builds) C-todo Category: TODO, specific item that needs to be accomplished in working towards a goal M-good-first-issue Misc: A good issue for newcomers to start with
Milestone

Comments

@Utumno
Copy link
Member

Utumno commented Jan 18, 2024

Doesn't need to be the full sha ten chars should be enough - helpful to track where a nightly was built from since we (wisely) stopped pushing the build commit to nightly.

@Utumno Utumno added C-todo Category: TODO, specific item that needs to be accomplished in working towards a goal M-good-first-issue Misc: A good issue for newcomers to start with A-build Area: build wrye Bash (nightlies to release builds) labels Jan 18, 2024
@Utumno Utumno added this to the 313 milestone Jan 18, 2024
@Infernio
Copy link
Member

Infernio commented Jan 18, 2024

Definitely a good idea. Note the comment though:

AppVersion = '313' # must represent a valid float

Some scripts rely on this for sure, not sure what else does. It might be best to create a new app_version_extra string constant and format with that, like this:

f'{bass.AppVersion}-{bass.app_version_extra}'

Then log that in the BashBugDump instead of bare AppVersion, same with the title bar. Would also let us easily add RC1 etc. to release candidates.

Or maybe do the formatting right in bass? Not sure what's better.

@Metallicow

This comment was marked as off-topic.

@Infernio Infernio changed the title Add commit sha to the nightly builds Add commit SHA to the nightly builds Jul 15, 2024
@Utumno Utumno modified the milestones: 313, 314 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: build wrye Bash (nightlies to release builds) C-todo Category: TODO, specific item that needs to be accomplished in working towards a goal M-good-first-issue Misc: A good issue for newcomers to start with
Projects
None yet
Development

No branches or pull requests

3 participants