Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpimath] ChassisSpeeds Discretize() and FromRelative() instance methods missing in C++ #7379

Closed
KangarooKoala opened this issue Nov 11, 2024 · 3 comments

Comments

@KangarooKoala
Copy link
Contributor

#7115 added instance method versions of discretize() and fromRelative() that modify the instance in-place instead of creating a new instance, and the old static versions were deprecated. This was only done in Java, though, and should be done in C++ too for parity.

Good first issue for those who either know C++ or are willing to learn.

@calcmogul
Copy link
Member

It was mainly done to reduce Java GC pressure, which C++ doesn't have.

@KangarooKoala
Copy link
Contributor Author

It would still be nice to maintain API parity, though.

@calcmogul
Copy link
Member

calcmogul commented Nov 11, 2024

I disagree. Mutable APIs on aggregates generally confuses users (see: the Java units API and our recent backslide to an immutable API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants