[cmd controllers] Java CommandXboxController.leftTrigger(EventLoop, double)
is wrong parameter order
#5826
Labels
component: command-based
WPILib Command Based Library
good first issue
Good for newcomers.
type: bug
Something isn't working.
Describe the bug
CommandXboxController
has overloads forleftTrigger()
andrightTrigger()
that specify the event loop the trigger will be bound to, as well as the threshold for the trigger. However, the left trigger overload isleftTrigger(EventLoop, double)
while the right trigger overload isrightTrigger(double, EventLoop)
.Expected behavior
I expect both methods to have the same parameter order. Looking at the other controllers, it seems that
EventLoop
last is the standard, and the C++ version also has theEventLoop
as the last parameter. (Though interestingly, theTrigger
constructor hasEventLoop
first.)The text was updated successfully, but these errors were encountered: