Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL rewrites for menus #541

Closed
jacobwise opened this issue Oct 6, 2021 · 3 comments · Fixed by #650
Closed

URL rewrites for menus #541

jacobwise opened this issue Oct 6, 2021 · 3 comments · Fixed by #650
Assignees
Labels
type: feature New functionality being added

Comments

@jacobwise
Copy link
Contributor

Would be nice if links in the menu response were rewritten to the frontend URL.

@wjohnsto wjohnsto added the type: feature New functionality being added label Oct 7, 2021
@wjohnsto
Copy link
Contributor

wjohnsto commented Oct 7, 2021

@apmatthews Can you take a look at this in the plugin and see if there's anything we can do, or any guidance we should document?

@apmatthews
Copy link
Member

@jacobwise Can you share an example of a query that isn't producing rewritten URLs in the menu response? We are already handling some menu URLs, but I think there may be edge cases where rewrites aren't occurring as expected. I'm trying to pinpoint those cases to figure out how best to address them.

@jacobwise
Copy link
Contributor Author

https://faust.craftedup.com/

const links = menuItems({ where: { location: MenuLocationEnum.PRIMARY }, first: 1000, }).nodes

I made the links custom and just put the relative link in per @wjohnsto as a workaround.

I added a page link at the end of the menu that goes to the Podcast page.

Screen Shot 2021-10-29 at 11 22 16 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New functionality being added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants