Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent Dependency updates might be a breaking change? #1941

Closed
1 task done
jasonbahl opened this issue Aug 21, 2024 · 2 comments
Closed
1 task done

recent Dependency updates might be a breaking change? #1941

jasonbahl opened this issue Aug 21, 2024 · 2 comments
Assignees

Comments

@jasonbahl
Copy link
Contributor

Description

The changes made in #1929 might be considered a breaking change as projects that use faust might now break until they install dependencies.

Need to verify this, but I think some packages such as glob and glob-promise are being used by faust packages but are no longer dependencies when they maybe should be?

Steps to reproduce

  1. Take an existing project using Faust
  2. update to use the latest faust (using yarn link)
  3. try and build the project and see what dependencies are now required when they weren't required before

Additional context

No response

@faustwp/core Version

canary

@faustwp/cli Version

3.0.2

FaustWP Plugin Version

n/a

WordPress Version

n/a

Additional environment details

n/a

Please confirm that you have searched existing issues in the repo.

  • Yes
@jasonbahl jasonbahl self-assigned this Aug 21, 2024
@josephfusco
Copy link
Member

Note that this should be considered before merging #1928

@josephfusco
Copy link
Member

This was fixed by #1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants