MTKA-1333: replace deprecated CircleCI Docker images #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindctrl
commented
Dec 7, 2021
| @@ -228,15 +229,12 @@ jobs: | |||
| - attach_workspace: | |||
| at: . | |||
|
|
|||
| - browser-tools/install-chrome | |||
There was a problem hiding this comment.
Without this, Chrome was no longer available. See: https://circleci.com/developer/images/image/cimg/php#browsers
There was a problem hiding this comment.
This could also be used to install chrome-driver, allowing us to remove our custom job, but I think that should be done in a different PR.
nickcernis
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the legacy CircleCI Docker images with the latest supported versions.
CircleCI is deprecating some existing Docker images and replaced them with newer, faster images. Legacy convenience images with the prefix
circleci/will be deprecated on Dec. 31, 2021.https://wpengine.atlassian.net/browse/MTKA-1333
Testing
Verify that CircleCI tests still run and pass as expected.