-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-exclude Trust Index Google Widget CSS from LazyLoad for CSS Background Images #6957
Comments
My workaround is this in an mu-plugin (well, use it in some plugin or child theme):
Actually, I use this array, but I have not tested whether there is a performance benefit. A few sites have 50 such images. Some sanity checking in the WP Rocket code would be nice. The most boring solution is to just set a limit of 50. [edited to fix formatting] |
Another case https://secure.helpscout.net/conversation/2712580830/513207/
|
Rel: https://secure.helpscout.net/conversation/2734821096/517921/ |
AC:
|
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
When using the Trust Index Google Widget plugin and LazyLoad for CSS background images, it creates a performance problem, especially on mobile.
The CSS file from that plugin contains A LOT of images. The resulting inline JS that we create is therefore very large.
This results in:
This problem could occur in any scenario where there are an excessive number of images in CSS, but it's very consistently happening with this specific plugin. Disabling the option improves performance in those cases.
To Reproduce
Steps to reproduce the behavior:
Additional context
Slack convos:
https://wp-media.slack.com/archives/C08N8J6VC/p1724876333198109
https://wp-media.slack.com/archives/C8L4EE8N9/p1725582448549079
Related tickets:
https://secure.helpscout.net/conversation/2699519664/510946/
https://secure.helpscout.net/conversation/2689724995/509272/
https://secure.helpscout.net/conversation/2692407860/509723/
https://secure.helpscout.net/conversation/2681783608/507952?folderId=8127822
https://secure.helpscout.net/conversation/2697455510/510593?folderId=7406897
https://secure.helpscout.net/conversation/2688555094/509064?folderId=8127840
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: