Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the used CSS is generated withing 90 seconds from enabling the RUCSS option #6304

Closed
wordpressfan opened this issue Dec 5, 2023 · 1 comment
Labels
module: remove unused css priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement

Comments

@wordpressfan
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version Yes
  • Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug
When we were fixing this issue (#6282) we found that the success message that appear after 90 seconds from enabling the RUCSS option shows that the used CSS is generated for homepage but at this point we are not sure about it.

As agreed on the slack discussion:

once RUCSS is enabled, we will have a dedicated code to create the job for home page in SaaS and after the 90 seconds pass we will send ajax request to a dedicated code to check the status and save the used CSS and then show the success message.

To Reproduce
Steps to reproduce the behavior:

  1. Go to WPR settings page
  2. Disable CRON to make sure that the used css will not be generated (add define( 'DISABLE_WP_CRON', true ) in wp-config.php)
  3. Enable RUCSS or clear used CSS if RUCSS is already enabled.
  4. Wait for 90 seconds (till the counter finishes)
  5. You will see the success message but the used CSS is not generated for homepage as mentioned in the message.

Expected behavior
We need to make sure that used CSS is really generated before showing the success message.

Additional context
Slack discussion: https://wp-media.slack.com/archives/CUT7FLHF1/p1701684109350099

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. module: remove unused css labels Dec 5, 2023
@piotrbak
Copy link
Contributor

This is not something that can be implemented in the nearest future.

@piotrbak piotrbak closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: remove unused css priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

No branches or pull requests

2 participants