Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WP-Optimize not compatible plugin #6005

Closed
piotrbak opened this issue Jun 22, 2023 · 1 comment · Fixed by #6023
Closed

Make WP-Optimize not compatible plugin #6005

piotrbak opened this issue Jun 22, 2023 · 1 comment · Fixed by #6023
Assignees
@mostafa-hisham
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting effort: [XS] < 1 day of estimated development time needs: documentation Issues which need to create or update a documentation noQA priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.14.2

Comments

@piotrbak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
WP Optimize comes with features that are duplicated with ours. Especially starting from 3.15 it might be problematic

Describe the solution you'd like
We'll make WP Optimize plugin not compatible with WP Rocket, in general.

Acceptance Criteria:

  1. We'll make WP Optimize not compatible with WP Rocket
  2. Equivalent message should be displayed when both plugins are active:
    image
  3. Dev Team: the confirmation of the fix should be presented using video
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting priority: medium Issues which are important, but no one will go out of business. needs: grooming needs: documentation Issues which need to create or update a documentation noQA labels Jun 22, 2023
@remyperona
Copy link
Contributor

Scope a solution ✅

In inc/admin/ui/notices.php

Function rocket_plugins_to_deactivate()

  • Add wp-optimize to the plugins array, using this key value pair: 'wp-optimize' => 'wp-optimize/wp-optimize.php'

Estimate the effort ✅

Effort [XS]

@remyperona remyperona added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Jun 22, 2023
@mostafa-hisham mostafa-hisham self-assigned this Jul 4, 2023
@mostafa-hisham mostafa-hisham mentioned this issue Jul 4, 2023
Merged
10 tasks
@piotrbak piotrbak added this to the 3.14.2 milestone Jul 9, 2023
@engahmeds3ed engahmeds3ed mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostafa-hisham mostafa-hisham

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting effort: [XS] < 1 day of estimated development time needs: documentation Issues which need to create or update a documentation noQA priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.14.2
Development

Successfully merging a pull request may close this issue.

add wp-optimize in plugins to deactivate wp-media/wp-rocket
3 participants
@remyperona @piotrbak @mostafa-hisham