Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation notice when using PHP 8.1 #4728

Closed
4 tasks
viobru opened this issue Feb 10, 2022 · 1 comment · Fixed by #4732
Closed
4 tasks

Deprecation notice when using PHP 8.1 #4728

viobru opened this issue Feb 10, 2022 · 1 comment · Fixed by #4732
Assignees
@remyperona
Labels
effort: [XS] < 1 day of estimated development time priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.11.1

Comments

@viobru
Copy link
Contributor

viobru commented Feb 10, 2022

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version ☑️
  • Used the search feature to ensure that the bug hasn’t been reported before ☑️

Describe the bug
A customer informed this deprecation notice is displayed when running PHP 8.1:

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /var/www/vhosts/f****g.com/httpdocs/wp-content/plugins/wp-rocket/inc/admin/upgrader.php on line 41

To Reproduce
Steps to reproduce the behavior:
N/A

Expected behavior
There should be no deprecation notice displayed when running PHP 8.1

Screenshots
N/A

Additional context
The customer took this from the debug file from wp-content.

Related ticket: https://secure.helpscout.net/conversation/1783564514/325265

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement needs: grooming labels Feb 14, 2022
@piotrbak piotrbak added this to the 3.10.9 milestone Feb 14, 2022
@remyperona
Copy link
Contributor

Scope a solution ✅

Replace the current sanitization code by sanitize_key() in upgrader.php, rocket_upgrader() line 41.

Estimate the effort ✅

Effort [XS]

@remyperona remyperona added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Feb 14, 2022
@remyperona remyperona self-assigned this Feb 15, 2022
@remyperona remyperona mentioned this issue Feb 15, 2022
Merged
5 tasks
@piotrbak piotrbak modified the milestones: 3.10.9, 3.11.1 Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remyperona remyperona

Labels
effort: [XS] < 1 day of estimated development time priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.11.1
Development

Successfully merging a pull request may close this issue.

Prevent PHP 8.1 deprecation notices wp-media/wp-rocket
4 participants
@remyperona @viobru @piotrbak @Mai-Saad