Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6959 UI issue after clear cache and apply LRC with certain template #30

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Oct 7, 2024

Description

Fixes 6959

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check the issue here for detailed scenario

Technical description

Create a new function to avoid ui issues for elements with a specific styling

Documentation

Explain how this code works. Diagrams & drawings are welcome.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

Copy link

codacy-production bot commented Oct 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.61% (target: -1.00%) 89.47% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (78ca211) 578 349 60.38%
Head commit (e301435) 635 (+57) 400 (+51) 62.99% (+2.61%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#30) 57 51 89.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal self-assigned this Oct 7, 2024
@Khadreal Khadreal requested a review from a team October 7, 2024 13:37
Miraeld
Miraeld previously approved these changes Oct 7, 2024
@Khadreal Khadreal requested review from Miraeld and a team October 7, 2024 15:22
@Khadreal Khadreal merged commit 9269480 into develop Oct 9, 2024
5 of 6 checks passed
@Khadreal Khadreal deleted the fix/6959/ui-issue-lrc branch October 9, 2024 10:44
Khadreal added a commit that referenced this pull request Oct 9, 2024
* Closes #6959 UI issue after clear cache and apply LRC with certain template (#30)

* Add new method to avoid conflicts with lrc -- :closes: wp-media/wp-rocket#6959

* Add tests for lrc conflicts method

* Fixed codacy error

* ✨ fixed codacy issues

---------

Co-authored-by: WordPress Fan <[email protected]>

* Change package version  (#36)

* Add new method to avoid conflicts with lrc -- :closes: wp-media/wp-rocket#6959

* Add tests for lrc conflicts method

* Fixed codacy error

* ✨ fixed codacy issues

* change package version number

---------

Co-authored-by: WordPress Fan <[email protected]>

---------

Co-authored-by: WordPress Fan <[email protected]>
Khadreal added a commit that referenced this pull request Oct 16, 2024
* Release v1.0.7 (#35)

* Closes #6959 UI issue after clear cache and apply LRC with certain template (#30)

* Add new method to avoid conflicts with lrc -- :closes: wp-media/wp-rocket#6959

* Add tests for lrc conflicts method

* Fixed codacy error

* ✨ fixed codacy issues

---------

Co-authored-by: WordPress Fan <[email protected]>

* Change package version  (#36)

* Add new method to avoid conflicts with lrc -- :closes: wp-media/wp-rocket#6959

* Add tests for lrc conflicts method

* Fixed codacy error

* ✨ fixed codacy issues

* change package version number

---------

Co-authored-by: WordPress Fan <[email protected]>

---------

Co-authored-by: WordPress Fan <[email protected]>

* Update version to 1.0.8

---------

Co-authored-by: WordPress Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue after clear cache and apply LRC with certain template
3 participants