Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk optimization isnot working #830

Closed
Mai-Saad opened this issue Feb 29, 2024 · 4 comments · Fixed by #832
Closed

Bulk optimization isnot working #830

Mai-Saad opened this issue Feb 29, 2024 · 4 comments · Fixed by #832
Assignees
Labels
AVIF Avif branch/feature priority: high Issues which should be resolved as quickly as possible severity: major type: bug
Milestone

Comments

@Mai-Saad
Copy link

Mai-Saad commented Feb 29, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => feature/avif and fix/826-prevent-reoptimize
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When apply bulk optimization, message displayed that all images optimized although it isnot

To Reproduce
Steps to reproduce the behavior:

  1. Fresh install/activation of feature/avif
  2. upload some images (small, medium, large) => optimization is done
  3. click restore original image for optimized image => next-gen removed and image(s) timestamp is updated
  4. got to bulk optimization and click imagify all => message displayed that images are optimized
    Screenshot from 2024-02-29 10-37-34

Expected behavior
A clear and concise description of what you expected to happen.
Bulk optimization is applied as same as on trunk (image timestamp/size is updated + next-gen is added as per enabled option)

Screenshots
If applicable, add screenshots to help explain your problem.

when click bulk optimization and display that images already optimized
Screenshot from 2024-02-29 10-51-05

after manually click on the optimize
Screenshot from 2024-02-29 10-56-23

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@Mai-Saad Mai-Saad added type: bug severity: major priority: high Issues which should be resolved as quickly as possible AVIF Avif branch/feature labels Feb 29, 2024
@Khadreal Khadreal self-assigned this Feb 29, 2024
@piotrbak piotrbak added this to the 2.2 milestone Feb 29, 2024
@piotrbak
Copy link

piotrbak commented Feb 29, 2024

@Mai-Saad Is it happening only with the 3rd step click restore original image for optimized image? What about the images that were uploaded before but not yet optimised? (is it a regression?)

@Mai-Saad
Copy link
Author

Is it happening only with the 3rd step click restore original image for optimized image? What about the images that were uploaded before but not yet optimized?(is it a regression?)

@piotrbak The same is happening with images uploaded before activating imagify. and yes it is regression.

@piotrbak
Copy link

@Khadreal Were you able to find the root cause?

@Khadreal
Copy link
Contributor

@Khadreal Were you able to find the root cause?

Not yet..still on it

@Khadreal Khadreal mentioned this issue Feb 29, 2024
14 tasks
@MathieuLamiot MathieuLamiot linked a pull request Feb 29, 2024 that will close this issue
14 tasks
@Mai-Saad Mai-Saad self-assigned this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature priority: high Issues which should be resolved as quickly as possible severity: major type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants