Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wpcs in plugin generation #120

Merged
merged 2 commits into from
Jan 27, 2018
Merged

fix wpcs in plugin generation #120

merged 2 commits into from
Jan 27, 2018

Conversation

thrijith
Copy link
Member

update code to remove WPCS warnings in plugin generated files #109

@gitlost
Copy link
Contributor

gitlost commented Jan 27, 2018 •
edited
Loading

Thanks very much for this PR and #121 @thrijith. I'm going to remove #109 from the 1.1.2 milestone as incomplete at this late stage, so will be reviewing soon after WP-CLI 1.5.0 releases....

gitlost
gitlost suggested changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@gitlost gitlost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @thrijith changed my mind about merging this for 1.5.0 after my bitbucket tests failed phpcs!

Am wondering about the changes for the tests directory, were you getting phpcs errors without these?

templates/plugin-bootstrap.mustache Outdated Show resolved Hide resolved
templates/plugin-test-sample.mustache Outdated Show resolved Hide resolved
@gitlost gitlost added this to the 1.1.2 milestone Jan 27, 2018
@gitlost gitlost merged commit d834c67 into wp-cli:master Jan 27, 2018
@gitlost
Copy link
Contributor

gitlost commented Jan 27, 2018

@thrijith in a bit of a rush (read panic) so took the liberty of removing the tests directory changes. Will revisit after 1.5.0, ta v much for the PR!

danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@gitlost
Merge pull request #120 from thrijith/GH-109-plugin
85af6ad 
fix wpcs in plugin generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitlost gitlost gitlost approved these changes

Assignees
No one assigned
Labels
command:scaffold-plugin
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@thrijith @gitlost