From 7d9bdf60e66c0f487a0d7b9e2703c6bb04dca900 Mon Sep 17 00:00:00 2001 From: Thrijith Thankachan Date: Tue, 9 Jan 2018 01:07:13 +0530 Subject: [PATCH] update code according to review --- templates/post_type.mustache | 24 +++++++-------- templates/post_type_extended.mustache | 43 +++++++++++++-------------- 2 files changed, 32 insertions(+), 35 deletions(-) diff --git a/templates/post_type.mustache b/templates/post_type.mustache index 753bdd876..e58c0ff37 100644 --- a/templates/post_type.mustache +++ b/templates/post_type.mustache @@ -1,5 +1,5 @@ register_post_type( '{{slug}}', array( - 'labels' => array( + 'labels' => array( 'name' => __( '{{label_plural_ucfirst}}', '{{textdomain}}' ), 'singular_name' => __( '{{label_ucfirst}}', '{{textdomain}}' ), 'all_items' => __( 'All {{label_plural_ucfirst}}', '{{textdomain}}' ), @@ -26,16 +26,16 @@ 'parent_item_colon' => __( 'Parent {{label_ucfirst}}:', '{{textdomain}}' ), 'menu_name' => __( '{{label_plural_ucfirst}}', '{{textdomain}}' ), ), - 'public' => true, - 'hierarchical' => false, - 'show_ui' => true, - 'show_in_nav_menus' => true, - 'supports' => array( 'title', 'editor' ), - 'has_archive' => true, - 'rewrite' => true, - 'query_var' => true, - 'menu_icon' => 'dashicons-{{dashicon}}', - 'show_in_rest' => true, - 'rest_base' => '{{slug}}', + 'public' => true, + 'hierarchical' => false, + 'show_ui' => true, + 'show_in_nav_menus' => true, + 'supports' => array( 'title', 'editor' ), + 'has_archive' => true, + 'rewrite' => true, + 'query_var' => true, + 'menu_icon' => 'dashicons-{{dashicon}}', + 'show_in_rest' => true, + 'rest_base' => '{{slug}}', 'rest_controller_class' => 'WP_REST_Posts_Controller', ) ); diff --git a/templates/post_type_extended.mustache b/templates/post_type_extended.mustache index ff17bd342..9fea44aaf 100644 --- a/templates/post_type_extended.mustache +++ b/templates/post_type_extended.mustache @@ -1,17 +1,18 @@ '', // Unused. Messages start at index 1. - /* translators: %s: permalink of {{label}}*/ - 1 => sprintf( __( '{{label_ucfirst}} updated. View {{label}}', '{{textdomain}}' ), esc_url( $permalink ) ), - 2 => __( 'Custom field updated.', '{{textdomain}}' ), - 3 => __( 'Custom field deleted.', '{{textdomain}}' ), - 4 => __( '{{label_ucfirst}} updated.', '{{textdomain}}' ), + 0 => '', // Unused. Messages start at index 1. + /* translators: %s: post permalink */ + 1 => sprintf( __( '{{label_ucfirst}} updated. View {{label}}', '{{textdomain}}' ), esc_url( $permalink ) ), + 2 => __( 'Custom field updated.', '{{textdomain}}' ), + 3 => __( 'Custom field deleted.', '{{textdomain}}' ), + 4 => __( '{{label_ucfirst}} updated.', '{{textdomain}}' ), /* translators: %s: date and time of the revision */ - 5 => isset( $_GET['revision'] ) ? sprintf( __( '{{label_ucfirst}} restored to revision from %s', '{{textdomain}}' ), wp_post_revision_title( (int) $_GET['revision'], false ) ) : false, - /* translators: %s: permalink of {{label}}*/ - 6 => sprintf( __( '{{label_ucfirst}} published. View {{label}}', '{{textdomain}}' ), esc_url( $permalink ) ), - 7 => __( '{{label_ucfirst}} saved.', '{{textdomain}}' ), - /* translators: %s: permalink of {{label}}*/ - 8 => sprintf( __( '{{label_ucfirst}} submitted. Preview {{label}}', '{{textdomain}}' ), esc_url( add_query_arg( 'preview', 'true', $permalink ) ) ), - - /* - * translators: %1$s :Publish box date format, see https://secure.php.net/manual/en/function.date.php. - * translators: %2$s: permalink of {{label}} - */ - 9 => sprintf( __( '{{label_ucfirst}} scheduled for: %1$s. Preview {{label}}', '{{textdomain}}' ), + 5 => isset( $_GET['revision'] ) ? sprintf( __( '{{label_ucfirst}} restored to revision from %s', '{{textdomain}}' ), wp_post_revision_title( (int) $_GET['revision'], false ) ) : false, + /* translators: %s: post permalink */ + 6 => sprintf( __( '{{label_ucfirst}} published. View {{label}}', '{{textdomain}}' ), esc_url( $permalink ) ), + 7 => __( '{{label_ucfirst}} saved.', '{{textdomain}}' ), + /* translators: %s: post permalink */ + 8 => sprintf( __( '{{label_ucfirst}} submitted. Preview {{label}}', '{{textdomain}}' ), esc_url( add_query_arg( 'preview', 'true', $permalink ) ) ), + /* translators: 1: Publish box date format, see https://secure.php.net/date 2: Post permalink */ + 9 => sprintf( __( '{{label_ucfirst}} scheduled for: %1$s. Preview {{label}}', '{{textdomain}}' ), date_i18n( __( 'M j, Y @ G:i' ), strtotime( $post->post_date ) ), esc_url( $permalink ) ), - /* translators: %s: permalink of {{label}}*/ + /* translators: %s: post permalink */ 10 => sprintf( __( '{{label_ucfirst}} draft updated. Preview {{label}}', '{{textdomain}}' ), esc_url( add_query_arg( 'preview', 'true', $permalink ) ) ), );