Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecurringExchange has deserialized ExchangeWorkflow field #182

Closed
Tracked by #152
SanjayVas opened this issue Oct 13, 2023 · 2 comments
Closed
Tracked by #152

RecurringExchange has deserialized ExchangeWorkflow field #182

SanjayVas opened this issue Oct 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@SanjayVas
Copy link
Member

This is related to #181.

The ExchangeWorkflow for a RecurringExchange is exposed as an immutable serialized message on descendant resources, but as a deserialized ExchangeWorkflow message on RecurringExchange itself. This is problematic when it comes to adding new API versions, as it means that new API versions would not be able to read RecurringExchange resources created in older API versions.
@SanjayVas SanjayVas added the bug Something isn't working label Oct 13, 2023
@SanjayVas SanjayVas mentioned this issue Oct 13, 2023
Open
12 tasks
@SanjayVas
Copy link
Member Author

It turns out the RecurringExchange resource is not exposed anywhere, so no need to worry about backwards-compatibility.

@SanjayVas SanjayVas mentioned this issue Oct 13, 2023
Closed
@SanjayVas
Copy link
Member Author

Closed by #185 and world-federation-of-advertisers/cross-media-measurement#1306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@SanjayVas