Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetExchangeRequest has a required party field. #138

Closed
Tracked by #152
SanjayVas opened this issue May 24, 2023 · 1 comment
Closed
Tracked by #152

GetExchangeRequest has a required party field. #138

SanjayVas opened this issue May 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@SanjayVas
Copy link
Member

SanjayVas commented May 24, 2023

GetExchangeRequest currently has a required oneof field named party.

From AIP-131:

The request message must not contain any other required fields, and should not contain other optional fields except those described in another AIP.

The implementation checks whether the authenticated user matches this field, and furthermore uses the value in the underlying query. Instead, the implementation should read the Exchange and then check whether it matches the caller.

@SanjayVas SanjayVas added the bug Something isn't working label May 30, 2023
@SanjayVas SanjayVas changed the title Drop party field from GetExchangeRequest GetExchangeRequest has a required party field. May 30, 2023
@SanjayVas SanjayVas mentioned this issue Jun 22, 2023
12 tasks
@SanjayVas
Copy link
Member Author

SanjayVas commented Oct 4, 2023

@SanjayVas SanjayVas closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant