Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that checks data patterns of result #181

Open
workhorsy opened this issue Sep 7, 2022 · 0 comments
Open

Add test that checks data patterns of result #181

workhorsy opened this issue Sep 7, 2022 · 0 comments

Comments

@workhorsy
Copy link
Owner

workhorsy commented Sep 7, 2022

We just had a bug where getting cache sizes from lscpu broke from changes to lscpu. This was broken for 1.5 years without me noticing. The fields for cache, such as "l2_cache_size" where wrong:

We were getting:

# python string
"256 KiB (8 instances)"

instead of:

# python int
262144

If we update the test_actual, we can make sure we are getting sane results.

  1. Make sure results are correct data types
  2. Make sure results match regex pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant