Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Job Post Message #4

Open
samgompers opened this issue Jun 2, 2021 · 2 comments
Open

[Design] Job Post Message #4

samgompers opened this issue Jun 2, 2021 · 2 comments
Assignees

Comments

@samgompers
Copy link
Collaborator

Work Page / Job Submission

Issue
The process of officially submitting a Job Post through the UI is not descriptive enough.

Suggestion
Make the state changes along the way descriptive. when a user clicks submit, he should be made aware of what is going on. When a job I submitted, he should be immediately taken to the Job posts page and see a placeholder for the submitted job that shows a pending status until the transaction has been confirmed on chain

@0xMayflower
Copy link
Member

@zzorum to resolve this issue we need to add an optional parameter confirmation to pass it here

tx.wait()

@zzorum
Copy link
Contributor

zzorum commented Jun 14, 2021

@0xMayflower @samgompers
I think it is not trivial to implement.

because in order to this. we need to maintain two arrays

  1. pending projects
  2. on-chain projects

but the problem is. 1) pending projects have no project id yet.
when we join two arrays, there should be a common key(like a foreign key in DB) to compare.
as 1) doesn't have any project id so there is no way to do it.

sure, title/ tokenURI ... can be one of the candidates. but not always identical.
estimating project id via "contract.getLatest() + 1" would be good option. but still, there is a chance to be a race condition when other clients create a project at the same time.

we can do this when there is a unique project id that can be decided before going to on-chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants