[Feature]: more control over logging

[RichieB2B]

Contact Details

richard.vandenberg (at) NCSC-NL

What should we build?

When the connection to the database fails, Orchestrator logs the connection string including password to stderr. We have no control over this because of this line:

orchestrator-core/orchestrator/app.py

Line 262 in 4a3e438

main_typer_app = typer.Typer()

We would like to be able to set pretty_exceptions_show_locals=False and other Typer() options.

Additionally this line sets up structlog in a very static way, causing all sorts of problems. See workfloworchestrator/nwa-stdlib#32
It would be great to be able to set our own handlers and formatting.

orchestrator-core/orchestrator/app.py

Line 117 in 4a3e438

initialise_logging()

Relevant pseudo code

No response

[acidjunk]

It would be very handy if we could pass some extra info to OrchestratorCore that allows one to configure/use the additional loggers config dict.

Then we can use it like it was supposed:
implementation of initialise_logging()

[pboers1988]

Hi Guys, thanks for the issue. Logging is something that could definitely receive some TLC, perhaps you would be willing to make a PR?