Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli/gbm patch #214

Merged
merged 31 commits into from
Nov 8, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
bfd9c1f
Remove version funcs from utils
jhnstn Oct 27, 2023
18bc715
Don't cast semver to string too quickly
jhnstn Oct 27, 2023
d1a5592
Use struct to build gb and gbm prs
jhnstn Oct 27, 2023
6eed0e5
Add prs to gb build
jhnstn Oct 27, 2023
9d06818
return a semver stuct from PriorVerion
jhnstn Oct 27, 2023
647af9b
Add base to pr build struct
jhnstn Oct 27, 2023
e847248
Get basic pr cherry-picking working
jhnstn Nov 1, 2023
552aca0
Use the tag to create a shallow clone
jhnstn Nov 1, 2023
42bd536
Add the dir to the command client struct
jhnstn Nov 2, 2023
7e19c74
Add prompts to manually resolve conflicts and edit changelog
jhnstn Nov 2, 2023
66e54f7
Dont prompt to resovle a conflict if there are no conflicts
jhnstn Nov 2, 2023
0ad0632
Remove debug logs
jhnstn Nov 2, 2023
fd2ace3
Clean up console prompts
jhnstn Nov 2, 2023
87af0f3
Guard against the commit not being available locally
jhnstn Nov 2, 2023
7e76e8b
use 'keep' instead of 'k' to keep the temp directory
jhnstn Nov 2, 2023
c06f425
print out files that are not opened
jhnstn Nov 2, 2023
696857c
Fix regression in 'all' command
jhnstn Nov 3, 2023
779b98f
Fix regression in 'gbm' command
jhnstn Nov 3, 2023
59b473f
Add repo to build struct
jhnstn Nov 3, 2023
fe048b2
Generalize the create patch function
jhnstn Nov 3, 2023
05cc6e3
update preview function to handle grafted branches
jhnstn Nov 3, 2023
c17b4f6
Skip cherry pick set up if there are no prs
jhnstn Nov 3, 2023
26478ce
Update gbm release to handle patches
jhnstn Nov 3, 2023
2a309d7
Fix how nvm installs node
jhnstn Nov 3, 2023
55d0c22
Merge branch 'cli/fix-node-again' into cli/gbm-patch
jhnstn Nov 3, 2023
b945cd3
Update all command to handle patches
jhnstn Nov 3, 2023
7067865
Go back to using the gh package preview PR function
jhnstn Nov 3, 2023
c6144ce
add binary
jhnstn Nov 3, 2023
fd0c768
Merge branch 'trunk' into cli/gbm-patch
jhnstn Nov 6, 2023
6942683
Clean up after merge
jhnstn Nov 6, 2023
e5e137c
Merge branch 'trunk' into cli/gbm-patch
jhnstn Nov 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update all command to handle patches
jhnstn committed Nov 3, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b945cd384e3b3c1c847b29a8ea6d9c303c5edf0b
17 changes: 17 additions & 0 deletions cli/cmd/release/prepare/all.go
Original file line number Diff line number Diff line change
@@ -41,6 +41,14 @@ var allCmd = &cobra.Command{
},
}

isPatch := version.IsPatchRelease()

if isPatch {
console.Info("Preparing a patch releases")
tagName := "rnmobile/" + version.PriorVersion().String()
setupPatchBuild(tagName, &build)
}

gbPr, err = release.CreateGbPR(build)
exitIfError(err, 1)
console.Info("Finished preparing Gutenberg PR")
@@ -50,7 +58,16 @@ var allCmd = &cobra.Command{
build = release.Build{
Dir: gbmDir,
Version: version,
Base: gh.Repo{
Ref: "trunk",
},
}

if isPatch {
tagName := version.PriorVersion().Vstring()
setupPatchBuild(tagName, &build)
}

pr, err := release.CreateGbmPR(build)
exitIfError(err, 1)
console.Info("Finished preparing Gutenberg Mobile PR")