Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.78.1 #4961

Merged
merged 8 commits into from
Jun 17, 2022
Merged

Release 1.78.1 #4961

merged 8 commits into from
Jun 17, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jun 16, 2022 •
edited by dcalhoun
Loading

Release for Gutenberg Mobile 1.78.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Change 2

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jun 16, 2022
Merged
Merged
Closed
@SiobhyB SiobhyB mentioned this pull request Jun 16, 2022
Merged
1 task
@SiobhyB SiobhyB requested a review from dcalhoun June 16, 2022 15:00
@SiobhyB SiobhyB marked this pull request as ready for review June 16, 2022 15:00
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jun 16, 2022 •
edited
Loading

🟢 Test new changes (Android)

Build: pr16764-0dfb596
Device: Pixel 6 (Android 12)

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jun 16, 2022 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: pr16764-0dfb596
Device: Pixel 6 (Android 12)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Jun 16, 2022 •
edited
Loading

🟢 Test new changes (iOS)

Build: pr18895-74c5bdb
Device: iPhone SE (iOS 15.6)

1 Skipped as it is for Android only.

@dcalhoun
Copy link
Member

dcalhoun commented Jun 16, 2022 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: pr18895-74c5bdb
Device: iPhone SE (iOS 15.6)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

dcalhoun
dcalhoun approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

My understanding is that we need to create a new GitHub Release based upon this branch prior to resolving conflicts and merging. Is that correct?

After that, we'll need to resolve conflicts and generate a bundle before merging.

fluiddot added 3 commits June 17, 2022 11:24
@fluiddot
Update Gutenberg ref with merge commit
47ab53e
@fluiddot
Merge branch 'trunk' into release/1.78.1
f1b15b1 
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
@fluiddot
Update bundle
551abfb
@fluiddot
Copy link
Contributor

My understanding is that we need to create a new GitHub Release based upon this branch prior to resolving conflicts and merging. Is that correct?

@dcalhoun That's correct, the tag created via the GitHub release should point to the latest commit of the release branch before the Gutenberg reference points to the merge commit from Gutenberg's trunk and it's updated with GB-mobile's trunk branch.

After that, we'll need to resolve conflicts and generate a bundle before merging.

I've done this in the following commits:

  • Update with trunk and solve conflicts: f1b15b1
  • Generate a new bundle: 551abfb

@fluiddot fluiddot merged commit e2dd159 into trunk Jun 17, 2022
@fluiddot fluiddot deleted the release/1.78.1 branch June 17, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiobhyB @dcalhoun @fluiddot