From e4a567347089bae585b87b9478a5636ad8f11587 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Thu, 4 Feb 2021 11:33:08 -0500 Subject: [PATCH 1/6] Update gutenberg ref to include npm run start updates --- gutenberg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gutenberg b/gutenberg index 912d28f52b..b6c98ecd38 160000 --- a/gutenberg +++ b/gutenberg @@ -1 +1 @@ -Subproject commit 912d28f52bc19e2a21d68223e0aeafad7af3dbf4 +Subproject commit b6c98ecd38c149911b8d1593e79f55508bed28f4 From 6d1475b4e6a1ef8b7f0016b20d0b9dbffcb505d8 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Wed, 6 Jan 2021 10:28:58 -0500 Subject: [PATCH 2/6] Make `npm run start` also do some cleanup Helps to avoid unexpected bugs that can arise when using the old version of `npm run start`. Now devs will need to explicitly choose to use the `npm run start:quick` command to get the old, riskier, `npm run start` behavior. --- package.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 0ca1120c4e..01290205f0 100644 --- a/package.json +++ b/package.json @@ -52,8 +52,9 @@ }, "scripts": { "postinstall": "npm ci --prefix gutenberg && cd jetpack/projects/plugins/jetpack && yarn install --frozen-lockfile --ignore-engines", - "start": "react-native start --config ./metro.config.js", - "start:reset": "npm run core clean:runtime && npm run start -- --reset-cache", + "start": "npm run core clean:runtime && npm run start:quick -- --reset-cache", + "start:quick": "react-native start --config ./metro.config.js", + "start:reset": "echo 'start:reset is deprecated. Please use `npm run start`, which does the same thing that start:reset used to do.'", "core": "cd gutenberg && npm run native", "prern-bundle": "patch-package --patch-dir gutenberg/packages/react-native-editor/metro-patch", "rn-bundle": "react-native bundle", From 66e576df38338543f51d40556d936e42e505e2f9 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Fri, 15 Jan 2021 18:07:37 -0500 Subject: [PATCH 3/6] Make `npm run start` direct to either `start:reset` or `start:quick` --- README.md | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 3272a5e174..3c73e1102e 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,7 @@ npm install ## Run ``` -npm run start +npm run start:reset ``` Runs the packager (Metro) in development mode. The packager stays running to serve the app bundle to the clients that request it. diff --git a/package.json b/package.json index 01290205f0..85d539b74a 100644 --- a/package.json +++ b/package.json @@ -52,9 +52,9 @@ }, "scripts": { "postinstall": "npm ci --prefix gutenberg && cd jetpack/projects/plugins/jetpack && yarn install --frozen-lockfile --ignore-engines", - "start": "npm run core clean:runtime && npm run start:quick -- --reset-cache", + "start": "echo 'The start command is not available in this project. It is strongly recommended to use start:reset to perform some cleanup when starting the metro bundler. Or you may use start:quick for a quicker startup, but this may lead to unexpected javascript errors when running the app.'", + "start:reset": "npm run core clean:runtime && npm run start:quick -- --reset-cache", "start:quick": "react-native start --config ./metro.config.js", - "start:reset": "echo 'start:reset is deprecated. Please use `npm run start`, which does the same thing that start:reset used to do.'", "core": "cd gutenberg && npm run native", "prern-bundle": "patch-package --patch-dir gutenberg/packages/react-native-editor/metro-patch", "rn-bundle": "react-native bundle", From 796c27310d71bb7875d766c20177206499d5ce48 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Thu, 4 Feb 2021 13:01:50 -0500 Subject: [PATCH 4/6] Give error message some color --- gutenberg | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gutenberg b/gutenberg index b6c98ecd38..47f0a20755 160000 --- a/gutenberg +++ b/gutenberg @@ -1 +1 @@ -Subproject commit b6c98ecd38c149911b8d1593e79f55508bed28f4 +Subproject commit 47f0a20755982f2051dc14aabfb3f7491c792082 diff --git a/package.json b/package.json index 85d539b74a..8f3b5b8631 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ }, "scripts": { "postinstall": "npm ci --prefix gutenberg && cd jetpack/projects/plugins/jetpack && yarn install --frozen-lockfile --ignore-engines", - "start": "echo 'The start command is not available in this project. It is strongly recommended to use start:reset to perform some cleanup when starting the metro bundler. Or you may use start:quick for a quicker startup, but this may lead to unexpected javascript errors when running the app.'", + "start": "echo \"\\x1b[33mThe start command is not available in this project. It is strongly recommended to use \\x1b[1:33mstart:reset\\x1b[0m\\x1b[33m to perform some cleanup when starting the metro bundler.\nOr you may use \\x1b[1:33mstart:quick\\x1b[0m\\x1b[33m for a quicker startup, but this may lead to unexpected javascript errors when running the app.\\x1b[0m\"", "start:reset": "npm run core clean:runtime && npm run start:quick -- --reset-cache", "start:quick": "react-native start --config ./metro.config.js", "core": "cd gutenberg && npm run native", From 5e4578d78716c4580d0d3a69364f6158ac08add1 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Fri, 5 Feb 2021 08:39:59 -0500 Subject: [PATCH 5/6] Update gutenberg ref to latest --- gutenberg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gutenberg b/gutenberg index 47f0a20755..dda6070c2f 160000 --- a/gutenberg +++ b/gutenberg @@ -1 +1 @@ -Subproject commit 47f0a20755982f2051dc14aabfb3f7491c792082 +Subproject commit dda6070c2f8ee2286273223e28ed19729836e1f9 From 657cd4cc9a0133267e2a447b1f8ab2c617cc6bb3 Mon Sep 17 00:00:00 2001 From: Matt Chowning Date: Fri, 5 Feb 2021 09:37:30 -0500 Subject: [PATCH 6/6] Update gutenberg ref --- gutenberg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gutenberg b/gutenberg index dda6070c2f..19c17f0243 160000 --- a/gutenberg +++ b/gutenberg @@ -1 +1 @@ -Subproject commit dda6070c2f8ee2286273223e28ed19729836e1f9 +Subproject commit 19c17f0243624bd3bcf72e827760aea764ee872c