Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.38.1 #2711

Merged
merged 12 commits into from
Oct 16, 2020
Merged

Release 1.38.1 #2711

merged 12 commits into from
Oct 16, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Oct 12, 2020

Release for Gutenberg Mobile 1.38.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Known Issues

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Aztec dependencies are pointing to a stable release.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
  • Gutenberg 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' is updated to the release number.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 12, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun requested a review from cameronvoell October 12, 2020 19:12
@ceyhun ceyhun marked this pull request as ready for review October 12, 2020 19:12
@cameronvoell
Copy link
Contributor

cameronvoell commented Oct 14, 2020

Regarding this issue: #2695
Using the latest WPAndroid build (WordPress-pr-13112-build-77031.apk), I am seeing the classic block on a jetpack site not opening in UBE issue fixed on my Samsung Galaxy S10+ running Android 10, but I do not see that issue fixed on my Samsung Galaxy Tab S3 running Android 9.

image
image

@guarani
Copy link
Contributor

guarani commented Oct 15, 2020

Using the latest WPAndroid build (WordPress-pr-13112-build-77031.apk), I am seeing the classic block on a jetpack site not opening in UBE issue fixed on my Samsung Galaxy S10+ running Android 10, but I do not see that issue fixed on my Samsung Galaxy Tab S3 running Android 9.

FWIW, I couldn't reproduce this while testing wordpress-mobile/WordPress-Android#13122 using a Samsung S10 running Android 10, despite multiple (~10) loads of the UBE. I tested Jetpack connected self-hosted sites, as well as Simple and Atomic WordPress.com sites.

@cameronvoell
Copy link
Contributor

cameronvoell commented Oct 15, 2020

I tested the latest of Marko's attempted fixes uses this test PR - #2711 (comment), and I am no longer seeing the issue on my Galaxy Tab S3. That test PR has this commit as its latest for the gutenberg repo - WordPress/gutenberg@78fa132

@marecar3 If we can get these PR's updated with the changes from that last commit, I think this hotfix will be ready to go. Nice job @marecar3 !

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all tested successfully :shipit:

@cameronvoell cameronvoell merged commit d593533 into trunk Oct 16, 2020
@cameronvoell cameronvoell deleted the release/1.38.1 branch October 16, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants