Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template for release PRs #2097

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 1, 2020

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link https://github.com/wordpress-mobile/gutenberg-mobile/compare/master...release/1.25.0?expand=1&template=release_pull_request.md

Or just use the normal pull request flow in github and then add this to url of the pull request preview page: ?expand=1&template=release_pull_request.md

Fixes #

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

## Changes

- Change 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding some guidance here for how to determine the relevant changes in the form of a comment (so it doesn't actually show up in in the rendered content, i.e., <!-- To determine the changes from the last release you need to... -->). I like moving as many of those kinds of directions to here as is reasonable because then updates to the directions will go through PR review instead of just being changed by one person.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that for the changes you can just look at the commits show in the pull request itself instead of doing the terminal git command.

Copy link
Contributor

@mchowning mchowning Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works too. I still think it might be nice to provide some guidance regarding what should be included as "Changes", but I don't feel strongly. Just having this template alone is a really great improvement. 😄

That does make me think though, is there any risk of us missing changes where

  1. change Add Flow to the project #1 is merged into gutenberg
  2. change Add Standard (style checking + auto formatting) to the project #2 is merged into gutenberg
  3. change Add Standard (style checking + auto formatting) to the project #2 is merged into gutenberg-mobile
  4. since ^that^ brought in change Add Flow to the project #1 already, there is no pr explicitly bringing change Add Flow to the project #1 into Gutenberg-mobile, so we miss it.

I think we're mostly ok because there should still be a release note for change #1 that would need to get merged, but we do forget if we forgot to update the release note we'd miss testing it too. This is more me just thinking out loud and not an issue with this PR.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergioEstevao !

@SergioEstevao SergioEstevao merged commit 5018d2b into develop Apr 8, 2020
@SergioEstevao SergioEstevao deleted the New-template-for-release-PRs branch April 8, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants