Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List shows an empty editable extra line #954

Closed
koke opened this issue May 3, 2019 · 2 comments · Fixed by #1129
Closed

List shows an empty editable extra line #954

koke opened this issue May 3, 2019 · 2 comments · Fixed by #1129
Assignees
Labels
Blocks [Type] Bug Something isn't working

Comments

@koke
Copy link
Member

koke commented May 3, 2019

Tested on WPiOS with 1.4: wordpress-mobile/WordPress-iOS#11628

  1. Add a list
  2. Notice there's an extra line at the bottom
  3. If you tap on it you can write

RPReplay_Final1556894057

The resulting HTML:

<!-- wp:list -->
<ul><li>One</li><li>Two</li></ul><p>what</p></ul>
<!-- /wp:list -->

cc @SergioEstevao

@koke koke added [Type] Bug Something isn't working Blocks labels May 3, 2019
@SergioEstevao SergioEstevao self-assigned this May 13, 2019
@SergioEstevao
Copy link
Contributor

So I investigated this issue and the reason we have this extra line is that the LayoutManager in iOS doesn't draw a line unless there is a character on it, so for us to have a bullet on an empty list we need to add an extra character to make it visible.
While in the Aztec editor wasn't an issue, on the blocks where each block is a separate Aztec TextView we will end up seeing a lot of empty line at the end of the list blocks.

@koke
Copy link
Member Author

koke commented Jun 17, 2019

👏 👏 👏 Thanks for figuring out this one, it was really bugging me 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants