Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Horizontal scroll persists when switching blocks #934

Closed
mchowning opened this issue Apr 26, 2019 · 2 comments · Fixed by #1270
Closed

Toolbar: Horizontal scroll persists when switching blocks #934

mchowning opened this issue Apr 26, 2019 · 2 comments · Fixed by #1270
Assignees
Labels

Comments

@mchowning
Copy link
Contributor

When editing a block with more items in the toolbar than fit on the screen, the toolbar can be horizontally scrolled to see/select the items that are not visible. This scroll position does not reset, however, when switching back to another block that does not have so many toolbar items. This results in the leftmost toolbar items (add block, undo, redo) being off the left of the screen.

This was tested on Android with a Pixel 3. I am not able to test whether this is an issue on iOS.

toolbar_scroll_1

Arguably, this might be desired behavior when switching between two blocks of the same type (i.e., you select heading block #1, scroll the toolbar all the way to the left, then select heading block #2, and the toolbar buttons stay in the same position), but it seems like a clear bug in a case like this where the toolbar items are so different.

Steps to Reproduce

  1. Open demo app
  2. Select a heading (such as "What is Gutenberg?")
  3. Scroll toolbar to the left so that the strikethrough icon is visible on the right.
  4. Select a paragraph block (such as "Hello World!")
  5. Observe that the toolbar is scrolled to the left and the left-most icons are off the left of the screen.
  6. Tap a toolbar item and the toolbar's scroll position will snap back so that the add block button is now visible on the left.

output

@mchowning
Copy link
Contributor Author

Upon further testing, it appears this is only an issue on Android.

@hypest
Copy link
Contributor

hypest commented Aug 8, 2019

Not sure if you're actively working on this one @mchowning , if so, better to move the ticket to the "In Progress" column in the project board, otherwise let's un-assign the ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants