Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph block is prematurely removed on backspace event #807

Closed
mkevins opened this issue Apr 3, 2019 · 8 comments
Closed

Paragraph block is prematurely removed on backspace event #807

mkevins opened this issue Apr 3, 2019 · 8 comments
Assignees
Labels

Comments

@mkevins
Copy link
Contributor

mkevins commented Apr 3, 2019

When all text is deleted from a paragraph, the block is removed prematurely. This issue has been encountered on Android Emulator, but may not occur on a physical device.

Steps to reproduce:

  • Place caret at the end of the "Hello World!" paragraph (after the '!')
  • Press [backspace] 12 times

Expected result:
The (empty) paragraph block remains focused, with the placeholder text ("Start writing...") visible.

Actual Result:
The paragraph block is removed. The focus changes to the previous block.

This behavior is mentioned in #699, and may be related to #783.

Screencast:

@mkevins mkevins self-assigned this Apr 3, 2019
@koke
Copy link
Member

koke commented Apr 3, 2019

I can confirm this happens on WPAndroid alpha-160

@koke koke added [Type] Bug Something isn't working Writing Flow labels Apr 3, 2019
@koke
Copy link
Member

koke commented Apr 4, 2019

I've seen a crash that seems related:

  1. Create a new post
  2. Tap the link button and enter some url and text
  3. Close the link UI
  4. Press backspace enough times to delete the whole link
  5. Crash

I've seen it happen with other combinations of typing and links, but this were steps where I could reproduce consistently.

Tested on WPAndroid alpha-160

@marecar3
Copy link
Contributor

marecar3 commented Apr 4, 2019

Hey @mkevins, thanks for the feedback!

Behavior from this issue is fixed in this PR: #756 as part of this issue: #699

I will add you as a reviewer in the PR so that you can check if everything is working alright.

@koke
Copy link
Member

koke commented Apr 4, 2019

So is it fine to close this as a duplicate of #699?

@marecar3
Copy link
Contributor

marecar3 commented Apr 4, 2019

Closing this one in favor of #699

@marecar3 marecar3 closed this as completed Apr 4, 2019
@mkevins
Copy link
Contributor Author

mkevins commented Apr 5, 2019

Hey @mkevins, thanks for the feedback!

Behavior from this issue is fixed in this PR: #756 as part of this issue: #699

I will add you as a reviewer in the PR so that you can check if everything is working alright.

Thanks @marecar3 ! I wasn't 💯 sure if the two issues would be solved by the same PR, so I split out this issue. Glad that the PR solves both! I'll test it out.

@mkevins
Copy link
Contributor Author

mkevins commented Apr 5, 2019

I just tested it (on the Android emulator), and it indeed solves the problem. Thank you!

@marecar3
Copy link
Contributor

marecar3 commented Apr 5, 2019

Thanks @mkevins !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants