Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default and paragraph placeholders don't match #637

Closed
koke opened this issue Feb 21, 2019 · 4 comments
Closed

Default and paragraph placeholders don't match #637

koke opened this issue Feb 21, 2019 · 4 comments
Assignees
Labels
Editor Chrome [Type] Enhancement Improves a current area of the editor

Comments

@koke
Copy link
Member

koke commented Feb 21, 2019

I missed this when reviewing #616, but the default block placeholder shows at a slightly different position than the paragraph placeholder so it moves the first time you tap on it.

Also, the border makes the text go up/down 1px when it gets and loses focus.

placeholders

cc @iamthomasbishop @SergioEstevao

@koke koke added [Type] Enhancement Improves a current area of the editor Editor Chrome labels Feb 21, 2019
@iamthomasbishop
Copy link
Contributor

Not sure if it's 100% related, but potentially related to the other issue that @pinarol and @etoledom are working on here.

I really wish we had access to box-shadow bc it would solve the shifting issue with a few lines of code 😪

@SergioEstevao
Copy link
Contributor

@koke was this on the latest on develop? Just tested and while I see the 1px moving up I don't see the big gap when moving from post placehoder to paragraph placeholder...

@koke
Copy link
Member Author

koke commented Feb 21, 2019

Yeah, WPiOS develop (3be1df9ebf) with the Podfile pointing to my local checkout with develop (bdf0202) and running metro

@pinarol
Copy link
Contributor

pinarol commented Feb 21, 2019

the border makes the text go up/down 1px when it gets and loses focus

this will be fixed with #622

But the issue about 'default block placeholder shows at a slightly different position than the paragraph placeholder so it moves the first time you tap on it.' is different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Chrome [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

4 participants