Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported Block Editor: Toolbar is taller than expected due to the block settings button #5720

Open
fluiddot opened this issue May 4, 2023 · 2 comments
Labels

Comments

@fluiddot
Copy link
Contributor

fluiddot commented May 4, 2023

Describe the bug
When editing an unsupported block, the toolbar displayed at the top of UBE (Unsupported Block Editor) is taller than expected. This seems to be caused by the block settings button that is pushing the rest of the elements.

To Reproduce
Steps to reproduce the behavior:

  1. Open a post in the browser and add an unsupported block (e.g. Table block).
  2. Open the same post in the app.
  3. Tap on the block and select "Edit using web editor"
  4. Once UBE loads, observe that the toolbar is taller than expected.

Expected behavior
The toolbar in UBE should be compact (i.e. not displaying unnecessary extra empty space). The block settings button shouldn't push the rest of the elements.

Screenshots

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 15.4.1
  • Version 22.3.0.1

Additional context
N/A

@fluiddot fluiddot added [Type] Bug Something isn't working Unsupported Block Editor labels May 4, 2023
@fluiddot fluiddot changed the title Toolbar is taller than expected due to the block settings button UBE: Toolbar is taller than expected due to the block settings button May 4, 2023
@fluiddot fluiddot changed the title UBE: Toolbar is taller than expected due to the block settings button Unsupported Block Editor: Toolbar is taller than expected due to the block settings button May 4, 2023
@fluiddot fluiddot mentioned this issue May 4, 2023
4 tasks
@fluiddot fluiddot added [Type] Bug Something isn't working and removed [Type] Bug Something isn't working labels May 4, 2023
@geriux
Copy link
Contributor

geriux commented May 4, 2023

For context of why this is like this now, here's the issue WordPress/gutenberg#48298 where it was discussed and the PR that introduced the changes WordPress/gutenberg#48435

@fluiddot
Copy link
Contributor Author

fluiddot commented May 4, 2023

For context of why this is like this now, here's the issue WordPress/gutenberg#48298 where it was discussed and the PR that introduced the changes WordPress/gutenberg#48435

Thanks @geriux for sharing the issue and the PR 🙇 ! From my side, I'd consider this a minor issue as it doesn't break the functionality. Actually, I think this is more of an enhancement we could do to compact the toolbar. I'll update the tags of the issue to reflect this.

@fluiddot fluiddot added [Type] Enhancement Improves a current area of the editor and removed [Type] Bug Something isn't working labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants